Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a memory leak occurs when createing a new type #9

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

zaxrok
Copy link

@zaxrok zaxrok commented Feb 6, 2018

I created a new instance of RosSchemas manually and filled values to Field of marshmallow.Schema.
When I tested it, there was no memory growing.

@asmodehn
Copy link
Member

asmodehn commented Feb 6, 2018

We need to keep travis test passing before we can merge anything, to make sure we don't break anything else... pleas compare with the master branch the tests that were passing and why they are not passing anymore...

@asmodehn
Copy link
Member

I recently merge a long PR in master to get all tests passing with travis, and make it easy to see if a PR breaks something or not.

Please rebase your branch on the recent master and we can ensure the tests are passing on travis.
Thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants