Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test code for memory growing problem #1

Open
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

zaxrok
Copy link

@zaxrok zaxrok commented Feb 7, 2018

I added test code to show memory growing in pros_httpbin/nodes/leaktest.py and fixed_leaktest.py
we are in serious because we are using it in the field.
could you make a pyros_schemas 's devel branch first?

@zaxrok zaxrok changed the title Rs 155 test code for memory growing problem Feb 7, 2018
@asmodehn
Copy link
Member

asmodehn commented Feb 7, 2018

Thanks for this. We can check the problem here at first.
I have a few other requests :

  • we need the minimum code, so please make a separate package for the leak test, with the minimum dependencies.
  • Please remove the 'ROS' layer if possible. If it is a python problem, then just running a python script is enough to show it, and we don't need all the ROS setup around ( catkin build, source env, roslaunch, etc.). Setting up a python environment for testing is much faster than setting up a ROS environment.
  • If you need an example about how to setup python package and work with python tests, you can check Nested implement pyros-msgs#14 and run the tests with tox.

It will help to setup the test environment, and will make the issue more clear.

If you are in an emergency, you can use your forked and patch version from a rosinstall, everything will work fine.
But as soon as you have some time, we need to write tests for this kind of problem, and integrate with the main repository. I have been working on an improved version of pyros-msgs and pyros-schemas, and when all the tests are passing I will merge that into the main branch. It will help stabilize the code to make sure next changes will not break what is already working.

It would be good if we can write memory leak tests for the new version. When you get time it will be good if you can switch to use these branches to check it, and be ready for next version.

@asmodehn
Copy link
Member

asmodehn commented Feb 7, 2018

Please also edit the author of these commit to a proper user.

@zaxrok
Copy link
Author

zaxrok commented Feb 8, 2018

I found that it's not a problem of pros_schemas, so I left an issue https://github.com/marshmallow-code/marshmallow/issues/732

@asmodehn
Copy link
Member

asmodehn commented Feb 8, 2018

Ah good to know thanks.

But it still means that users, on robots, care about memory usage details, and it would be good if we can find a way to check memory usage automatically during testing of pyros-msgs and pyros-schemas.

Let me know if you have an idea or a piece of code that can be used to check memory usage, or reference cycle with pytest (using objgraph, or pympler, or something similar). pyros-dev/pyros-msgs#27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants