Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add: folder for notebooks #3

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add: folder for notebooks #3

wants to merge 1 commit into from

Conversation

GHCamille
Copy link

No description provided.

Copy link
Member

@frgfm frgfm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!
A few suggestions:

  • why not adding directly non empty notebooks?
  • let's name the files without spaces (underscores as replacement for instance)
  • to avoid too much "content" files in the repo, I might suggest an alternative: only having a markdown file with links to the notebook + colab options, and we create another repo that will hold all the notebooks for pyronear projects. I did it for a personal project: https://github.com/frgfm/torch-cam/tree/main/notebooks (and the notebooks are actually hosted here https://github.com/frgfm/notebooks/tree/main/torch-cam)

What do you think?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants