Add loading spinner on login #172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanderlindenma
commented
Nov 8, 2024
| """ | ||
| input_style_unchanged = {"width": "250px"} | ||
| empty_style_unchanged = {"": ""} |
There was a problem hiding this comment.
Would be cleaner to user {} instead, but then mypy complains because it wants to know the type of empty_style_unchanged and it seems python does not infer types for empty dictionaries => using {"": ""} seems simpler than bringing in a whole typing library to handle that error only (from typing import Dict, Optional ... empty_style: Dict[str, Optional[str]] = {}).
vanderlindenma
commented
Nov 8, 2024
| empty_style_unchanged, | ||
| empty_style_unchanged, | ||
| hide_element_style, | ||
| ) |
There was a problem hiding this comment.
@MateoLostanlen @fe51 @RonanMorgan Another example where Dash does not scale well. In a "sane" 😉 web framework:
- You shouldn't have to repeatedly include placeholders for things you don't want to update: Just pass a map/dict of what you do want to change and the framework should know the rest should be left untouched.
- You shouldn't have to go back and forth between the parameters in the head of your function and the return to match the order of the declared outputs and with the order of the returns => just return a map each time.
Maybe there are workarounds to fix that in Dash but this kind of update behavior should really come out of the box.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-08.at.10.08.58.AM.mov