Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Switches to ruff for linting #115

Merged
merged 8 commits into from
Oct 30, 2023
Merged

style: Switches to ruff for linting #115

merged 8 commits into from
Oct 30, 2023

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Oct 25, 2023

This PR introduces the following modifications:

  • removes autoflake, flake8 and switches to ruff
  • updates black & mypy
  • fixes all small issues with style checks

Any feedback is welcome!

@frgfm frgfm added the type: enhancement New feature or request label Oct 25, 2023
@frgfm frgfm added this to the 0.1.2 milestone Oct 25, 2023
@frgfm frgfm requested a review from a team October 25, 2023 16:00
@frgfm frgfm self-assigned this Oct 25, 2023
@MateoLostanlen
Copy link
Member

Salut @frgfm thanks for the pr and thanks for introducing me to ruff the speed is pretty impressive.

Overall ok for me but you have your bandit test crashing

@frgfm
Copy link
Member Author

frgfm commented Oct 26, 2023

Overall ok for me but you have your bandit test crashing

Oh that's "normal". The job was disabled, so I reenabled it. I wanted to keep the PR about linting so I left that to avoid further modifications of the codebase (compared to linting, changing things to fix bandit can change the code behaviour)

Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok all good then !

@MateoLostanlen MateoLostanlen merged commit b550875 into main Oct 30, 2023
7 of 8 checks passed
@MateoLostanlen MateoLostanlen deleted the style branch October 30, 2023 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants