Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Adds continuous deployment through DockerHub #114

Merged
merged 4 commits into from
Oct 25, 2023
Merged

ci: Adds continuous deployment through DockerHub #114

merged 4 commits into from
Oct 25, 2023

Conversation

frgfm
Copy link
Member

@frgfm frgfm commented Oct 25, 2023

This PR introduces the following modifications:

  • makes the docker image slightly lighter
  • updates the docker build job and adds an autodeploy job using Dockerhub

Any feedback is welcome!

@frgfm frgfm added type: enhancement New feature or request topic: build Related to build, installation & CI labels Oct 25, 2023
@frgfm frgfm added this to the 0.1.2 milestone Oct 25, 2023
@frgfm frgfm requested a review from a team October 25, 2023 15:20
@frgfm frgfm self-assigned this Oct 25, 2023
MateoLostanlen
MateoLostanlen approved these changes Oct 25, 2023
View reviewed changes
Copy link
Member

@MateoLostanlen MateoLostanlen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks a lot @frgfm !

@frgfm frgfm merged commit 323d244 into main Oct 25, 2023
7 of 8 checks passed
@frgfm frgfm deleted the autodeploy branch October 25, 2023 15:54
@frgfm frgfm mentioned this pull request Oct 25, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MateoLostanlen MateoLostanlen MateoLostanlen approved these changes

Assignees

@frgfm frgfm

Labels
topic: build Related to build, installation & CI type: enhancement New feature or request
Projects
None yet
Milestone
0.1.2
Development

Successfully merging this pull request may close these issues.
2 participants
@frgfm @MateoLostanlen