Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hm/all deterministic #1914

Merged
merged 2 commits into from
Nov 22, 2024
Merged

Conversation

hessammehr
Copy link
Contributor

Current post-processing behaviour skips models with only deterministic variables. Applying this change will return consistent samples regardless of whether sample sites are present. Fixes #1911

@fehiepsi
Copy link
Member

Could you fix the lint issue @hessammehr?

@hessammehr hessammehr force-pushed the HM/all_deterministic branch 2 times, most recently from 057cbf2 to 2bf8267 Compare November 21, 2024 22:43
Current post-processing behaviour skips models with only deterministic variables. Applying this change will return consistent samples regardless of whether `sample` sites are present.
Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the bug, @hessammehr!

@fehiepsi fehiepsi merged commit f87f40e into pyro-ppl:master Nov 22, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MCMC returns no samples when model contains deterministic variables only
2 participants