Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Latent exclude deterministic #1901

Merged
merged 3 commits into from
Nov 10, 2024

Conversation

juanitorduz
Copy link
Contributor

Closes #1861

The test fails in the master branch but passes with the change in the _predictive function.

Is this enough or do we want to test something else?

Copy link
Member

@fehiepsi fehiepsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @juanitorduz!

@fehiepsi fehiepsi merged commit b9bacee into pyro-ppl:master Nov 10, 2024
4 checks passed
@juanitorduz juanitorduz deleted the latent-exclude-deterministic branch November 10, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude_deterministic argument in Predictive does not apply for models with discrete latents
2 participants