Fix handling of event dimensions in ComposeTransform (fixes #1893).
#1894
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fehiepsi
reviewed
Oct 23, 2024
numpyro/distributions/transforms.py
Outdated
| @@ -282,7 +282,7 @@ def __eq__(self, other): | |||
|
|
|||
| def _get_compose_transform_input_event_dim(parts): | |||
| input_event_dim = parts[-1].domain.event_dim | |||
| for part in parts[len(parts) - 1 :: -1]: | |||
| for part in parts[len(parts) - 1 : len(parts) : -1]: | |||
There was a problem hiding this comment.
Thanks for the catch! I think we need to ignore the -1 part here. Maybe using parts[:-1][::-1] to be less confusing?
There was a problem hiding this comment.
It was surprised to me that
x = [10]
print(x[-2::-1]) # Output: [10]
There was a problem hiding this comment.
Sounds great!
tillahoffmann
force-pushed
the
compose-transform-event-dim
branch
from
84f5d79
to
2938a7c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #1893, I think. It looks like the implicit end in the slice caused some trouble if there's only one transform.