feat: add api compat arg to NS.get_samples #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
if group_by_chain is true, I guess we need to add singleton dimension in front. Otherwise we can raise error if it is true. |
|
I like the grouping by chain suggestion. Arviz wants that for the shape. |
fehiepsi
approved these changes
Oct 7, 2024
|
The CI error is unrelated and blocking the actual unit tests. Happy to rebase when a sphinx-fixing PR is merged. |
Pushing a fix in #1882 |
|
The fix is merged thanks to @juanitorduz! |
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
Signed-off-by: nstarman <[email protected]>
nstarman
force-pushed
the
jaxns-group-by-chain
branch
from
42b2e21
to
488316c
Compare
|
👍. Rebased. |
|
@fehiepsi, is this good to go in? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard API, which tools like
arvizrely on, requires the argumentgroup_by_chain.See
numpyro/numpyro/infer/mcmc.py
Line 702 in e462292
This PR adds the kwarg as a no-op.
Fixes #1879