Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up non PEP 440 wheel filename deprecation language #13012

Conversation

notatallshaw
Copy link
Member

@notatallshaw notatallshaw commented Oct 13, 2024

This PR does the following

  1. Removes catching InvalidVersion as I found out more recent versions of packaging (which are now vendored) no longer raise this for parse_wheel_filename: parse_{sdist,wheel}_filename: don't raise InvalidVersion packaging#721
  2. Cleaned up langauge based on @ichard26 suggestions and added an extra test based on the filename example

This is the new warning:

DEPRECATION: Wheel filename 'simple-0.1_1-py2-none-any.whl' is not correctly normalised. Future versions of pip will raise the following error:
  Invalid wheel filename (invalid version): simple-0.1_1-py2-none-any
  
   pip 25.1 will enforce this behaviour change. A possible replacement is to rename the wheel to use a correctly normalised name (this may require updating the version in the project metadata). Discussion can be found at https://github.com/pypa/pip/issues/12938

@notatallshaw notatallshaw changed the title Clean up PEP 440 wheel filename deprecation language Clean up non PEP 440 wheel filename deprecation language Oct 13, 2024
@notatallshaw notatallshaw force-pushed the clean-up-non-PEP-440-wheel-filename-deprecation-language branch from e41a572 to 64b9dbc Compare October 13, 2024 17:49
@sbidoul sbidoul added this to the 24.3 milestone Oct 13, 2024
@sbidoul
Copy link
Member

sbidoul commented Oct 20, 2024

Thanks @notatallshaw !

@sbidoul sbidoul merged commit 53ba3fb into pypa:main Oct 20, 2024
32 checks passed
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants