Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix range when no range in osim #4

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix range when no range in osim #4

wants to merge 2 commits into from
+14 −13

Conversation

aceglia
Copy link
Collaborator

@aceglia aceglia commented Feb 10, 2023 •
edited by pariterre
Loading

This change is Reviewable

@aceglia aceglia mentioned this pull request Feb 10, 2023
Closed
@Ipuch
Copy link
Contributor

Ipuch commented Oct 24, 2023 •
edited
Loading

I think I need this PR to be merged ! :)
@pariterre can we give full rights to Amedeo ?

pariterre
pariterre requested changes Oct 25, 2023
View reviewed changes
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @aceglia)

osim_to_biomod/converter.py line 419 at r1 (raw file):

                for q, qrange in enumerate(q_range):
                    if qrange:

The difference is subtle between "q_range" and "qrange" "ranges" or "q_ranges" for the former?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pariterre pariterre pariterre requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aceglia @Ipuch @pariterre