Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] Added transparent kinogram per phase #95

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

EveCharbie
Copy link
Contributor

@EveCharbie EveCharbie commented Oct 20, 2023

This change is Reviewable

@EveCharbie EveCharbie changed the title Added transparent kinogram per phase [RTR] Added transparent kinogram per phase Oct 20, 2023
@codecov
Copy link

codecov bot commented Oct 20, 2023

Codecov Report

Attention: 123 lines in your changes are missing coverage. Please review.

Files Coverage Δ
bioviz/__init__.py 0.00% <0.00%> (ø)

📢 Thoughts on this report? Let us know!.

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed all commit messages.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @EveCharbie)


bioviz/__init__.py line 345 at r1 (raw file):

            self.analyses_ligament: AnalysePanel | None = None

            self.c3d__file__name = None

Is this intended or a typo?

Copy link
Contributor Author

@EveCharbie EveCharbie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on @pariterre)


bioviz/__init__.py line 345 at r1 (raw file):

Previously, pariterre (Pariterre) wrote…

Is this intended or a typo?

Haha yep, fixed :)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 1 of 1 files at r2, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @EveCharbie)

@pariterre pariterre merged commit ac77ed4 into pyomeca:master Oct 26, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants