Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RTR] some little test on preparing the data for animation of tracked markers. #714

Merged
merged 7 commits into from
Jul 13, 2023

Conversation

Ipuch
Copy link
Collaborator

@Ipuch Ipuch commented Jul 11, 2023

addressing pyomeca/bioviz/issues/94

This change is Reviewable

@codecov
Copy link

codecov bot commented Jul 11, 2023

Codecov Report

Patch coverage: 62.74% and project coverage change: +0.11 🎉

Comparison is base (05c65eb) 81.64% compared to head (fe6bb40) 81.75%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #714      +/-   ##
==========================================
+ Coverage   81.64%   81.75%   +0.11%     
==========================================
  Files         123      124       +1     
  Lines       13942    14059     +117     
==========================================
+ Hits        11383    11494     +111     
- Misses       2559     2565       +6     
Impacted Files Coverage Δ
bioptim/interfaces/biorbd_model.py 86.29% <14.28%> (-3.60%) ⬇️
bioptim/optimization/solution.py 88.04% <78.37%> (+3.40%) ⬆️
...act/contact_forces_inequality_constraint_muscle.py 64.91% <100.00%> (+51.45%) ⬆️
...forces_inequality_constraint_muscle_excitations.py 63.63% <100.00%> (ø)
bioptim/interfaces/biomodel.py 81.00% <100.00%> (+0.58%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Ipuch Ipuch changed the title some little test on preparing the data for animation of tracked markers. [RTR] some little test on preparing the data for animation of tracked markers. Jul 13, 2023
pariterre
pariterre previously approved these changes Jul 13, 2023
Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 4 of 4 files at r2, 1 of 1 files at r3, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @Ipuch)

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 4 of 4 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)


bioptim/optimization/solution.py line 1405 at r4 (raw file):

        # detect this is the same instance over each phase
        if not all([isinstance(nlp.model, BiorbdModel) for nlp in self.ocp.nlp]):

You can use mro

Copy link
Member

@pariterre pariterre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG
:lgtm:

Reviewed 2 of 2 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @Ipuch)

@pariterre pariterre merged commit 9237b31 into pyomeca:master Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants