Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve timezone information when validating Pendulum DateTimes #189

Merged
merged 1 commit into from
Jun 13, 2024

Conversation

chrisguidry
Copy link
Contributor

Fixes #188

Copy link

codecov bot commented Jun 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

📢 Thoughts on this report? Let us know!

Copy link
Collaborator

@yezz123 yezz123 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting this @chrisguidry

@yezz123 yezz123 merged commit 678c867 into pydantic:main Jun 13, 2024
19 checks passed
@chrisguidry chrisguidry deleted the timezone-fix branch June 13, 2024 15:08
@mikenerone
Copy link

mikenerone commented Jun 14, 2024

Isn't this kindof a "release it now" thing? It's broken, and it's a regression.

@yezz123
Copy link
Collaborator

yezz123 commented Jun 14, 2024

Isn't this kindof a "release it now" thing? It's broken, and it's a regression.

Will try to release it by today

@yezz123
Copy link
Collaborator

yezz123 commented Jun 14, 2024

@chrisguidry @mikenerone its ready tag/v2.8.2 once the release is approved its will be in PyPi

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pendulum DateTime wrapper losing tz and timezone values in 2.8.1
3 participants