add parsing of pendulum_dt from unix time #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
07pepa
force-pushed
the
and-unix-time-parsing
branch
from
1e55159 to
643c081
Compare
|
i did not want to wait for #169 |
07pepa
force-pushed
the
and-unix-time-parsing
branch
2 times, most recently
from
8a7ed17 to
5f43c88
Compare
07pepa
force-pushed
the
and-unix-time-parsing
branch
2 times, most recently
from
731b68a to
7946d9c
Compare
|
@yezz123 sorry for more noise with this one but it is ready to review/merge as extra i wanted to have full feature parity with https://docs.pydantic.dev/latest/api/standard_library_types/#datetimedatetime since i do not know case when pydantic itself would parse it differently i kept pendulum parsing as fallback option and even made it settable |
* improve type checking in pendulum_dt.py * added tests
07pepa
force-pushed
the
and-unix-time-parsing
branch
from
7946d9c to
a37529e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.