Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pendulum.DateTime instantiation from dt.datetime #158

Closed
wants to merge 2 commits into from

Conversation

docek
Copy link

@docek docek commented Mar 17, 2024

Copy link
Member

@Kludex Kludex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a test for it?

@docek
Copy link
Author

docek commented Mar 17, 2024

Can we add a test for it?

Definitely, I have very quickly tried to add few lines on GitHub, but the merge tests did not go through because the "Import block is un-sorted or un-formatted". To be honest, I do not see where is the problem.

@mikenerone
Copy link

mikenerone commented May 3, 2024

Is there any reason the analogous changes shouldn't be applied to Date (accepting datetime.date objects) and Duration (accepting datetime.timedelta objects)? I currently do these in my local enhancements. It seems to me like pretty inconsistent behavior without these.

@07pepa
Copy link
Contributor

07pepa commented May 31, 2024

@yezz123 this can be closed already present here with test and merged #176

@yezz123 yezz123 closed this May 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants