Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pip-compile call #111

Merged
merged 1 commit into from
Dec 29, 2023

Conversation

theunkn0wn1
Copy link
Contributor

Updates the pip-compile call.

Copy link

codecov bot commented Dec 13, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (843b753) 100.00% compared to head (e7726a7) 100.00%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #111   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            9         9           
  Lines          642       642           
  Branches       159       159           
=========================================
  Hits           642       642           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kludex
Copy link
Member

Kludex commented Dec 14, 2023

What does this do?

@theunkn0wn1
Copy link
Contributor Author

What does this do?

@samuelcolvin has the details.

@Kludex
Copy link
Member

Kludex commented Dec 27, 2023

@theunkn0wn1 If you tell me the details, we can speed up here.

@theunkn0wn1
Copy link
Contributor Author

Resolves the GHSA I filled on pydantic/pydantic.

The pip compile call with default parameters is insecure and already caused an incident.

@Kludex Kludex merged commit 453ebf1 into pydantic:main Dec 29, 2023
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants