🐛 fix all deprecated functions #101
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #101 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 9 9
Lines 637 637
Branches 158 158
=========================================
Hits 637 637
☔ View full report in Codecov by Sentry. |
* ➕ Include python 3.12 to CI * ⬆️ add python 3.12 to classifiers
|
please review |
1 task
Kludex
reviewed
Oct 23, 2023
| @@ -11,11 +12,11 @@ | |||
| from pydantic_core import PydanticCustomError, core_schema | |||
|
|
|||
| try: | |||
| import pycountry # type: ignore[import] | |||
| except ModuleNotFoundError: # pragma: no cover | |||
| import isocountry | |||
There was a problem hiding this comment.
I've transitioned from using "pycountry" to the new "isocountry" library, which essentially amounts to a hard fork. You can find my customized version at https://github.com/yezz123/isocountry. It appears that "pycountry" may no longer be actively maintained, hence this shift. 😄
Kludex
reviewed
Oct 23, 2023
| @@ -39,14 +40,14 @@ classifiers = [ | |||
| ] | |||
| requires-python = '>=3.7' | |||
| dependencies = [ | |||
| 'pydantic>=2.0.3', | |||
| 'pydantic>=2.4.2', | |||
There was a problem hiding this comment.
I guess to match and support the latest changes in pydantic so far 🤔
1 task
Kludex
reviewed
Nov 2, 2023
| @@ -35,7 +35,7 @@ jobs: | |||
| fail-fast: false | |||
| matrix: | |||
| os: [ubuntu, macos, windows] | |||
| python-version: ['3.7', '3.8', '3.9', '3.10', '3.11'] | |||
| python-version: ['3.8', '3.9', '3.10', '3.11', '3.12'] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Selected Reviewer: @Kludex