Skip to content

Commit

Permalink
Fix the calling of the private function in simulation.py
Browse files Browse the repository at this point in the history
  • Loading branch information
Akhil-Sharma30 committed Jan 21, 2024
1 parent 12ca10e commit 91036e4
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions pybamm/simulation.py
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ def _set_up_and_parameterise_experiment(self):
op_conds.duration = dt

# Set up model for experiment
self.set_up_and_parameterise_model_for_experiment()
self._set_up_and_parameterise_model_for_experiment()

def _set_up_and_parameterise_model_for_experiment(self):
"""
Expand Down Expand Up @@ -394,7 +394,7 @@ def build(self, check_model=True, initial_soc=None):
self._model_with_set_params = self._model
self._built_model = self._model
else:
self.set_parameters()
self._set_parameters()
self._mesh = pybamm.Mesh(self._geometry, self._submesh_types, self._var_pts)
self._disc = pybamm.Discretisation(self._mesh, self._spatial_methods)
self._built_model = self._disc.process_model(
Expand All @@ -414,7 +414,7 @@ def build_for_experiment(self, check_model=True, initial_soc=None):
if self.op_conds_to_built_models:
return
else:
self.set_up_and_parameterise_experiment()
self._set_up_and_parameterise_experiment()

# Can process geometry with default parameter values (only electrical
# parameters change between parameter values)
Expand Down

0 comments on commit 91036e4

Please sign in to comment.