-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Phase contrast quality of life improvements #674
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the in-place datacube modification, I think we may want to somehow prevent someone from accidentally preprocessing the same dataset more than once. Perhaps there is a clean way to set some flag on the datacube or add an entry to its metadata to indicate that it has already been modified, and then warn or error if you try to run it again.
I like the blind parallax a lot. It would be nice if the plotting was behind a flag, so that I could use this as the basis of a parallax feature in the GUI. Also, can you really handle transpose just by changing the direction of the rotation? Maybe it's happening at a different stage than I am used to but that just seemed fishy.
To be honest I'm not a huge fan of this feature, but a user working on very large datasets asked for it and figured I'd oblige. I think if the user is explicitly setting
Sure, I'll add a flag for the plotting. It would be amazing to add this functionality to the GUI!
It suffices to perform these two operations, yes:
if transpose:
rotation_angle_deg *= -1
if transpose:
shifts_ang = xp.flip(shifts_ang, axis=1) |
I see, I just missed the second step of flipping. |
Various quality of life improvements for the
phase
module. Namely:max_batch_size
option in parallaxpreprocess
andreconstruct
(only useful for shifting cross-correlated VBFs)aligned_bf_image_guess
option in parallaxpreprocess
to initialize cross-correlation withguess_common_aberrations
function which accepts microscope geometry parameters (rotation/transpose), as-well as common aberrations (defocus, stig, coma, spherical), and computes the analytical BF shifts -- using them to compute the aligned (and optionally upsampled) BF image