Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hot fix for fit amorphous ring #663

Merged
merged 2 commits into from
Jun 7, 2024
Merged

hot fix for fit amorphous ring #663

merged 2 commits into from
Jun 7, 2024

Conversation

smribet
Copy link
Collaborator

@smribet smribet commented Jun 6, 2024

quick fix for passing an initial guess for coefficients for fitting amorphous rings

Copy link
Member

@sezelt sezelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you just reduce the indentation of lines 129-142 instead? The new lines seem to just be a copy, and there's no reason to duplicate if they run regardless of the if block

@smribet
Copy link
Collaborator Author

smribet commented Jun 6, 2024

Yes!

@sezelt sezelt merged commit c2f6ea3 into py4dstem:dev Jun 7, 2024
6 checks passed
@smribet smribet deleted the polar branch June 8, 2024 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants