You get a Mixin, you get a Mixin, every ptycho class gets a Mixin #597
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…her, especially for positions
smribet
approved these changes
Jan 22, 2024
bsavitzky
pushed a commit
to bsavitzky/py4DSTEM
that referenced
this pull request
Mar 12, 2024
You get a Mixin, you get a Mixin, every ptycho class gets a Mixin Former-commit-id: 8096597
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Draft PR for long-awaited
phase_contrastrefactor using Mixins to de-duplicate code.Also includes various bugfixes, improvements, and new features.
Will update description soon with more information and attach a notebook to help with reviewing.