Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More strain less stress #522

Merged
merged 14 commits into from
Oct 23, 2023
Merged

More strain less stress #522

merged 14 commits into from
Oct 23, 2023

Conversation

smribet
Copy link
Collaborator

@smribet smribet commented Sep 19, 2023

This PR is to update the strain branch by cleaning up the structure and adding more processing and plotting options.

@smribet
Copy link
Collaborator Author

smribet commented Oct 16, 2023

The linter is failing on the functions that are in py4DSTEM/process/latticevectors.
@bsavitzky do you want to keep these functions or can I remove them? If we keep them, I just need to do a bit of restructuring.

@bsavitzky bsavitzky marked this pull request as ready for review October 23, 2023 17:13
@bsavitzky
Copy link
Member

This module is now functional - i.e. the bugs which prevented strain mapping from working at all with calibrated braggvectors have been fixed - however, significant testing is still required, and in particular QR rotation handling needs to be reviewed and thoroughly tested. All that said, I'm merging this so that users who are currently stuck can proceed. Anyone using this module should plan to confirm the correctness of QR rotations manually for your datasets until the next update to this module is released. Thanks to everyone for your patience....

@bsavitzky bsavitzky merged commit 247322c into py4dstem:dev Oct 23, 2023
6 checks passed
@smribet smribet deleted the strain_take_2 branch November 30, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants