Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix polyfill issues #979

Merged
merged 1 commit into from
Jan 5, 2024
Merged

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Jan 5, 2024

Fixes Issue

#978

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Install the latest dependencies before testing this PR

@Aman035 Aman035 linked an issue Jan 5, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jan 5, 2024

File: package.json

  1. There is a missing closing brace '}' after the "config" property.

  2. There is a missing comma ',' after the closing brace '}' of the "config" property.

  3. The "devDependencies" property is not closed with a closing brace '}'.

File: packages/examples/sdk-frontend-react/project.json

  1. There is a missing closing brace '}' after the "serve" target.

  2. There are missing commas ',' after the value of the "defaultConfiguration" property in the "serve" target.

  3. There are missing commas ',' after the values of the "buildTarget" and "hmr" properties in the "serve" target.

File: packages/examples/sdk-frontend-react/src/webpack.config.js

No issues found.

File: yarn.lock

No issues found.

Overall, the syntax errors and missing commas in the package.json and project.json files need to be corrected.

@Aman035 Aman035 merged commit d6c8f34 into main Jan 5, 2024
1 check passed
@Aman035 Aman035 deleted the fix-sdk-frontend-react-polyfill branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Polyfill Issue with examples/sdk-frontend-react
2 participants