Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

971 bug onchain functions related to userchannel does not work with viem signer #977

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Jan 4, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

mohammeds1992 and others added 30 commits July 14, 2023 15:34
* fix: signer compatibility with viem and ethers

* fix: revert space changes
akp111 and others added 26 commits October 5, 2023 15:09
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

github-actions bot commented Jan 4, 2024

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  1. In the import section, there are several imports that are not used:

    • Remove the following import: import { PushAPI } from '../pushapi/PushAPI';
  2. In the PushNotificationBaseClass class:

    • The createChannel method is missing a closing brace } at the end.
    • Inside the createChannel method, there is a missing closing brace } after the throw new Error('viem signer is not provided'); line.
    • Inside the createChannel method, the createChannelPromise variable is not being used. Remove this line of code: const createChannelPromise = contract!['createChannelWithPUSH'](channelType, identityBytes, fees, this.getTimeBound(), { gasLimit: 1000000 });
    • Inside the createChannel method, change !contract.write to !pushSigner.isViemSigner(this.signer).
    • Inside the createChannel method, there is a missing closing brace } at the end of the catch block.
    • Inside the createChannel method, the createChannelRes variable is not being used. Remove this line of code: createChannelRes = createChannelTrx.hash;
    • Inside the createChannel method, the return statement is missing a closing parenthesis ). Add ) before the semicolon ; in the return statement.
  3. In the updateChannel method:

    • The parameter let updateChannelRes; should be removed. The variable updateChannelRes is already declared inside the method.
    • Inside the updateChannel method, there is a missing closing parenthesis ) after the contract!['updateChannelMeta'](account line.
    • Inside the updateChannel method, the updateChannelPromise variable is not being used. Remove this line of code: const updateChannelPromise = contract!['updateChannelMeta'](account,.
    • Inside the updateChannel method, the return statement is missing a closing parenthesis ). Add ) before the semicolon ; in the return statement.
  4. In the verifyChannel method:

    • The parameter let verifyTrxRes; should be removed. The variable verifyTrxRes is already declared inside the method.
    • Inside the verifyChannel method, there is a missing closing brace } before the throw statement throw new Error(error.message);.
    • Inside the verifyChannel method, there is an unnecessary throw new Error(error.message); statement. You can remove this line of code.

File: packages/restapi/tests/lib/notification/channel.test.ts

  1. In the channel :: update section, there is a missing closing bracket } at the end of the test case.

  2. In the channel :: create section, there is a missing closing bracket } at the end of the test case.

  3. In the channel :: settings section, there is a missing closing bracket } at the end of the test case.

All looks good.

@mohammeds1992 mohammeds1992 self-requested a review January 4, 2024 10:33
@mohammeds1992 mohammeds1992 merged commit 1129b71 into main Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants