Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix nft chat examples, version bump up #976

Merged
merged 1 commit into from
Jan 4, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Jan 4, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Aman035 Aman035 requested a review from mohammeds1992 January 4, 2024 07:07
Copy link

github-actions bot commented Jan 4, 2024

File: packages/examples/sdk-backend-node/chat/nftChat.ts

  1. There is a missing closing brace at the end of the skipExample function.

  2. There is a missing closing brace at the end of the runNFTChatClassUseCases function.

  3. There are two redundant await keywords before the PushAPI.initialize calls for userBob and userKate.

  4. There is a missing closing brace at the end of the stream.on(CONSTANTS.STREAM.DISCONNECT callback.

File: packages/examples/sdk-backend-node/package.json

  1. There are no mistakes or typos in the package.json file. All looks good.

@mohammeds1992 mohammeds1992 merged commit e069fc5 into main Jan 4, 2024
1 check passed
@Aman035 Aman035 deleted the fix-nft-chat-examples branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants