Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix unsubscribe with viem signers #974

Merged
merged 1 commit into from
Jan 4, 2024
Merged

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Jan 4, 2024

Fixes Issue

#934

Changes proposed

  • Change primaryType in unsubscribe fn to match TypeInfo

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

@Aman035 Aman035 linked an issue Jan 4, 2024 that may be closed by this pull request
@Aman035 Aman035 requested a review from mohammeds1992 January 4, 2024 06:46
Copy link

github-actions bot commented Jan 4, 2024

All looks good.

@mohammeds1992 mohammeds1992 merged commit 2d61da4 into main Jan 4, 2024
1 check passed
@Aman035 Aman035 deleted the fix-viem-unsubscribe branch January 4, 2024 07:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Fail on Unsubscribe
2 participants