Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

803 bug pushapinotificationlist not working as expected with channels filter #962

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Dec 22, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

arn4b and others added 26 commits October 3, 2023 17:52
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer (#736)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

---------

Co-authored-by: Nilesh Gupta <[email protected]>
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  1. In the ChannelInfoOptions type, there is a missing closing curly bracket (}) after the setting?: boolean property.

  2. In the SubscribeUnsubscribeOptions type, there is a missing closing curly bracket (}) after the settings?: UserSetting[] property.

  3. In the UserSetting type, the value property should be optional. Change value?: number | {lower: number, upper: number}; to value?: number | {lower?: number, upper?: number};.

  4. In the FeedsOptions type, there is a missing closing curly bracket (}) after the raw?: boolean property.

  5. In the ChannelSearchOptions type, there is a missing closing curly bracket (}) after the comment.

  6. In the INotification type, there is a missing closing curly bracket (}) after the body: string property.

  7. In the IPayload type, the meta property should be optional. Change meta?: { ... }; to meta?: { ... } | undefined;.

  8. In the IConfig type, there is a missing closing curly bracket (}) after the hidden?: boolean property.

  9. In the IAdvance type, there is a missing closing curly bracket (}) after the counter: number property.

File: packages/restapi/src/lib/pushNotification/notification.ts

  1. In the list method, there is a missing closing curly bracket (}) after the }) in the promises.map callback function.

  2. In the subscriptions method, there is a missing closing curly bracket (}) after the }); in the return await PUSH_USER.getSubscriptions line.

File: packages/restapi/src/lib/user/getFeedsPerChannel.ts

  1. In the getFeedsPerChannel function, there is a missing closing curly bracket (}) after the .catch block.

File: packages/restapi/tests/lib/notification/notification.test.ts

  1. In the describe('PushAPI.notification functionality', () => { block, there is an unclosed backtick in the comment.

  2. In the beforeEach(async () => { block, there is a missing closing parenthesis ()) after the provider line.

  3. In the beforeEach(async () => { block, there is a missing closing parenthesis ()) after the provider line.

  4. In the beforeEach(async () => { block, there is a missing closing parenthesis ()) after the } = options || {}; line.

  5. In the first it('Should return feeds without signer object when an account is passed', async () => { block, there is a missing closing parenthesis ()) after the }); it('Should throw error without signer object when an account is not passed', async () => { line.

  6. In the second it('Should return feeds when signer with provider is used', async () => { block, there is a missing closing parenthesis ()) after the { account: '0xD8634C39BBFd4033c0d3289C4515275102423681', // console.log(response) line.

  7. In the third it('Should return feeds when viem is used', async () => { block, there is a missing closing parenthesis ()) after the `{
    channels: ['0xD8634C39BBFd4033c0d3289C4515275102423681'],
    raw: true,
    ...
    ...
    'eip155:11155111:0x53474D90663de06BEf5D0017F450730

@mohammeds1992 mohammeds1992 merged commit d738ead into main Jan 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - PushAPI.notification.list not working as Expected with channels filter
7 participants