Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix case for member Status string #954

Merged
merged 1 commit into from
Dec 22, 2023
Merged

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Dec 21, 2023

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

In the file chat.ts:

  1. Line 16: The option groupType is hardcoded as 'default'. It should be dynamically assigned based on the input.
  2. Line 27: There is a missing closing brace '}' after participants object.
  3. Line 57: The parameter options of count function should have a type annotation.
  4. Line 70: The parameter status of status function should have a type annotation.
  5. Line 71: The property pending should not be used before it is defined.
  6. Line 80: The property participant should not be used before it is defined.
  7. Line 84: There is a missing closing brace '}' after permissions object.
  8. Line 92: There is a missing closing brace '}' after info object.
  9. Line 95: The parameter options of update function should have a type annotation.
  10. Line 101: There is a missing closing brace '}' after ManageGroupOptions interface.
  11. Line 107: There is a missing closing brace '}' after GetGroupParticipantsOptions interface.
  12. Line 125: There is a missing closing brace '}' after ParticipantStatus interface.

In the file pushAPITypes.ts:

  1. Line 32: There is a missing closing brace '}' after ManageGroupOptions interface.
  2. Line 35: There is a missing closing brace '}' after RemoveFromGroupOptions interface.
  3. Line 39: There is a missing closing brace '}' after GetGroupParticipantsOptions interface.
  4. Line 50: There is a missing closing brace '}' after GroupUpdateOptions interface.
  5. Line 55: There is a missing closing brace '}' after InfoOptions interface.
  6. Line 63: There is a missing closing brace '}' after ParticipantStatus interface.

All looks good.

@Aman035 Aman035 merged commit bb658a6 into main Dec 22, 2023
1 check passed
@Aman035 Aman035 deleted the fix-case-for-memberStatus-string branch March 6, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - String case for Participant status in a Grp
2 participants