Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed hardcoded msg for group rules in msg input #925

Merged
merged 1 commit into from
Dec 5, 2023

Conversation

KlausMikhaelson
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 5, 2023

File: packages/uiweb/src/lib/components/chat/MessageInput/MessageInput.tsx

Based on the code provided, I have found a few mistakes and suggestions for improvement:

  1. In the padding prop of the TypebarSection component, there is a space before the template string interpolation " ${pgpPrivateKey ? '13px 16px' : ''}". Please remove the space to avoid any unwanted spaces in the rendered output.

  2. In the background prop of the TypebarSection component, the ?. optional chaining operator is not necessary. You can directly access theme.backgroundColor.messageInputBackground without the optional chaining.

  3. In the borderRadius and border prop of the second TypebarSection component, there are missing curly braces around the object values. Please add curly braces {} around theme.borderRadius.messageInput and theme.border.messageInput.

  4. In the second TypebarSection component, there is a syntax error with the border prop. It seems that the prop is missing a value. Please provide a valid value for the border prop.

  5. Inside the Object.keys(chatFeed || {}).length && chatFeed?.groupInformation condition, there is no closing parenthesis for the condition. Please add a closing parenthesis before the JSX code block.

  6. In the rendering logic for the Connect component inside the ConnectWrapper, there is a missing closing parenthesis for the isNotVerified() condition. Please add a closing parenthesis after the accessLoading ? 'Verify Access' statement.

  7. Inside the second Connect component, there is a missing opening curly brace { for the approveLoading ? ... condition. Please add an opening curly brace before the approveLoading ? statement.

  8. Inside the second Connect component, there is an unnecessary closing parenthesis after the Color="#fff" prop for the Spinner component. Please remove the closing parenthesis to avoid a syntax error.

  9. In the second Section component, there is a missing closing parenthesis for the condition (!!pgpPrivateKey && !verificationSuccessfull). Please add a closing parenthesis after (!!pgpPrivateKey && !verificationSuccessfull).

  10. Based on the code snippet provided, there is no closing curly brace } for the initial ternary condition (autoConnect ? ... : !checkIfIntent({ chat: chatFeed, account: account! }) && Object.keys(chatFeed || {}).length ? ... ). Please make sure to include the closing curly brace } for the entire ternary condition.

Please review and make the necessary corrections.

@mohammeds1992 mohammeds1992 merged commit 4e7000c into main Dec 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants