Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: workaround for socket response #924

Merged
merged 2 commits into from
Dec 4, 2023
Merged

Conversation

mishramonalisha76
Copy link
Collaborator

No description provided.

Copy link

github-actions bot commented Dec 2, 2023

In ChatProfile.tsx:

  • There are multiple chatId props commented out. Please remove the unnecessary commented out props.

In ChatViewComponent.tsx:

  • There is a commented out CreateGroupModal component. Please remove it.

In ChatViewListTest.tsx:

  • There is a commented out MessageInput component. Please remove it.

In ApproveRequestBubble.tsx:

  • There is a missing closing curly brace after the try block in the handleApproveChatRequest function.
  • In the Button component, the ternary operator is not closed properly. Please wrap the Spinner component in curly braces.
  • The min-height property of the Button component should be removed.

In ChatViewList.tsx:

  • The ChatStatus object is not closed properly. Please add a closing curly brace after the INVALID_CHAT property.
  • There is a missing useEffect dependency in the useEffect hook that fetches group information.
  • There is a missing closing parenthesis in the useEffect hook that fetches group information.
  • There is a missing closing parenthesis in the useEffect hook that fetches messages.
  • There is a scrollToBottom function used without being defined. Please define it or remove the unused code.
  • There is a missing closing parenthesis in the useEffect hook that fetches messages.
  • There is a missing closing parenthesis in the setFilteredMessages function after setting the messages state.
  • The ifBlurChat function is not closed properly. Please add a closing parenthesis before the closing curly brace.
  • The renderDate function is not closed properly. Please add a closing parenthesis before the closing curly brace.

In MessageInput.tsx:

  • The file is empty. Please add the necessary code.

All other files look good.

@mohammeds1992 mohammeds1992 merged commit f765f51 into main Dec 4, 2023
1 check failed
@mishramonalisha76 mishramonalisha76 deleted the workaround-socket branch March 5, 2024 06:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants