Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supported address format #911

Merged
merged 473 commits into from
Dec 4, 2023
Merged

Supported address format #911

merged 473 commits into from
Dec 4, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Dec 1, 2023

No description provided.

mohammeds1992 and others added 22 commits October 5, 2023 15:02
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

github-actions bot commented Dec 4, 2023

In the file packages/restapi/src/lib/pushNotification/channel.ts:

  • Line 7: There is a typo in the comment. It should be "search query" instead of "serach query".
  • Line 8: The closing parentheses is missing. It should be }) instead of ).
  • Line 36: There is an extra throw new Error() statement inside the search() method. It should be removed.
  • Line 47: There is a typo in the comment. It should be "channel" instead of "channell".
  • Line 59: There is a closing parentheses missing. It should be }) instead of ).
  • Line 62: There is an extra throw new Error() statement inside the subscribers() method. It should be removed.
  • Line 70: There is a typo in the comment. It should be "recipients" instead of "recipents".
  • Line 73: There is a missing closing parentheses. It should be }) instead of ).
  • Line 77: There is an extra throw new Error() statement inside the send() method. It should be removed.

In the file packages/restapi/src/lib/pushNotification/delegate.ts:

  • Line 29: There is a typo in the comment. It should be "channel" instead of "channell".
  • Line 36: There is an extra closing parentheses. It should be )} instead of }).
  • Line 61: There is an extra closing parentheses. It should be )} instead of }).
  • Line 76: There is a typo in the comment. It should be "delegate" instead of "delegator".
  • Line 83: There is a missing closing parentheses. It should be )) instead of )}.
  • Line 90: There is an extra throw new Error() statement inside the add() method. It should be removed.
  • Line 100: There is a missing closing parentheses. It should be }) instead of )}.
  • Line 110: There is an extra throw new Error() statement inside the remove() method. It should be removed.

In the file packages/restapi/src/lib/pushNotification/notification.ts:

  • Line 21: There is a typo in the comment. It should be "notification" instead of "notifcaiton".
  • Line 49: There is a missing closing parentheses. It should be )} instead of }).
  • Line 82: There is a missing closing parentheses. It should be ) instead of ]}.
  • Line 118: There is a missing closing parentheses. It should be ]}) instead of ]}.
  • Line 141: There is a missing closing parentheses. It should be )} instead of }).
  • Line 155: There is an extra throw new Error() statement inside the list() method. It should be removed.
  • Line 173: There is an extra closing parentheses. It should be }) instead of )}.
  • Line 177: There is an extra closing parentheses. It should be }) instead of )}.
  • Line 182: There is an extra closing parentheses. It should be )}) instead of )}}.
  • Line 186: There is an extra throw new Error() statement inside the subscriptions() method. It should be removed.
  • Line 196: There is a missing closing parentheses. It should be }) instead of )}.
  • Line 208: There is an extra throw new Error() statement inside the subscribe() method. It should be removed.

In the file packages/restapi/src/lib/pushNotification/pushNotificationBase.ts:

  • Line 62: There is a missing closing parentheses. It should be }) instead of )}.
  • Line 84: There is an extra throw new Error() statement. It should be removed.
  • Line 92: There is a missing closing parentheses. It should be )} instead of }).
  • Line 102: There is an extra closing parentheses. It should be }) instead of )}.
  • Line 110: There is an extra closing parentheses. It should be } instead of ])}.
  • Line 117: There is a missing closing parentheses. It should be } instead of ])}.
  • Line 124: There is an extra closing parentheses. It should be }) instead of )}.
  • Line 130: There is an extra throw new Error() statement. It should be removed.
  • Line 177: There is an extra closing parentheses. It should be } instead of ]]}.

File packages/restapi/tests/lib/notification/channel.test.ts doesn't exist.

File packages/restapi/tests/lib/notification/delegate.test.ts doesn't exist.

File packages/restapi/tests/lib/notification/notification.test.ts doesn't exist.

All other files seem to be fine.

@mohammeds1992 mohammeds1992 merged commit 8de11ff into main Dec 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
7 participants