Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scroll to bottom, loading the feed without message #910

Merged
merged 4 commits into from
Dec 1, 2023

Conversation

pritipsingh
Copy link
Contributor

No description provided.

Copy link

github-actions bot commented Dec 1, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

  • The import statement for Section component is missing.
  • The import statement for styled-components is missing.
  • The import statement for CreateGroupModal, MODAL_BACKGROUND_TYPE, and MODAL_POSITION_TYPE from "@pushprotocol/uiweb" is missing.
  • The import statement for ChatView from "@pushprotocol/uiweb" is missing.
  • The ChatViewComponentCard component is used but it is not defined.

File: packages/examples/sdk-frontend-react/src/app/app.tsx

  • A closing } is missing after the iconColorPrimary value in the customDarkTheme object.
  • A closing } is missing after the checkForWeb3Data function.
  • A closing } is missing after the onChangeCAIP function.
  • A closing } is missing after the useEffect hook.

Copy link

github-actions bot commented Dec 1, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

  1. The import statement for the styled-components library is missing.
  2. The import statement for the Section component is missing.
  3. The import statement for the CreateGroupModal, MODAL_BACKGROUND_TYPE, and MODAL_POSITION_TYPE is using an incorrect path.

All looks good.

File: packages/examples/sdk-frontend-react/src/app/app.tsx

  1. There is a missing closing parenthesis at the end of the customDarkTheme object definition.
  2. The checkForWeb3Data function is missing a closing brace.
  3. The onChangeCAIP function is missing a closing brace.

All looks good.

File: packages/uiweb/src/lib/components/chat/ChatViewList/ChatViewList.tsx

  1. There is a missing closing parenthesis for the setTimeout function in the scrollToBottom method.

All looks good.

File: packages/uiweb/src/lib/hooks/chat/usePushChatSocket.ts

  1. There is a missing closing brace for the setAcceptedRequestMessage method. It should be closed after the if statement.

All looks good.

@@ -387,7 +387,7 @@ export const ChatViewList: React.FC<IChatViewListProps> = (
}
)}
</Section>
{chatFeed &&
{Object.keys(chatFeed || {}).length &&
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

here add !!Object.keys(chatFeed || {}).length

Copy link

github-actions bot commented Dec 1, 2023

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

  1. In line 6, there is an unused import of CreateGroupModal.
  2. In lines 12-13, there are two commented out lines of code that are not being used and can be removed.
  3. In line 14, there is an extra whitespace before the closing > of ChatViewComponentCard component.
  4. In line 18, onVerificationFail callback is not defined or implemented, which may cause an error.
  5. In line 24, there is an extra closing parenthesis before the closing tag of ChatView component.
  6. In line 34, ChatViewComponentTest is not a meaningful name for the component. Consider using a more descriptive name.

File: packages/app/src/app.tsx

  1. There is an unclosed closing bracket in line 24, the customDarkTheme object should have } at the end.
  2. In line 25, there is a missing closing parenthesis after the array [].
  3. In line 27, there is a missing comma after iconColorPrimary property.
  4. In line 62, there is a missing closing parenthesis in the onChangeCAIP function.
  5. There is an unclosed closing brace in line 106, the useEffect hook should have } at the end.

File: packages/uiweb/src/lib/components/chat/ChatViewList/ChatViewList.tsx

  1. In line 114, there is an unused variable scrollTop in the onScroll function.
  2. In line 50, there is an extra opening brace { before the messages?.messages && condition.
  3. In line 83, there is an unused variable messageLoading in the condition of the ternary operator.
  4. In lines 80-81 and 85-88, there are unused variables chat and index in the map function. Consider using the index for the key prop instead of index.

File: packages/uiweb/src/lib/hooks/chat/usePushChatSocket.ts

  1. In line 32, there is a missing closing parenthesis after the closing brace of the setAcceptedRequestMessage function.
  2. In lines 39-42, there are missing closing braces } for the condition.
  3. In line 57, there is an extra closing parenthesis ) before the closing tag of the removeSocketEvents function.
  4. In line 58, there is an unclosed closing brace } after the closing tag of the removeSocketEvents function.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 0393cdf into main Dec 1, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants