Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get subscribe response #900

Merged
merged 476 commits into from
Nov 29, 2023
Merged

Get subscribe response #900

merged 476 commits into from
Nov 29, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Nov 29, 2023

No description provided.

akp111 and others added 24 commits October 5, 2023 15:09
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

File: packages/restapi/src/lib/channels/getSubscribers.ts

  • Line 9: Remove the extra comma at the end of the import statement for 'ResourceLimits'.
  • Line 14: Fix the typo in the function parameter name from 'GetChannelSubscribersOptionsType' to 'GetChannelSusbcribersOptionsType'.
  • Line 19: Fix the typo in the function parameter name from 'SubscribeOptionsType' to 'GetChannelSubscribersOptionsType'.
  • Line 24: Remove the duplicate closing parenthesis ')' after the error message.
  • Line 27: Add a closing parenthesis ')' after the error message for 'limit must be greater than 0'.
  • Line 30: Add a closing parenthesis ')' after the error message for 'limit must be lesser than or equal to 30'.
  • Line 42: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 45: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 49: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 53: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 57: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 62: Add a missing closing parenthesis ')' after the 'if' statement condition.
  • Line 63: Add a missing opening curly brace '{' before the return statement.
  • Line 65: Add a missing closing curly brace '}' after the return statement.
  • Line 72: Add a missing closing curly brace '}' after the catch block.
  • Line 73: Add a missing opening curly brace '{' before the catch block.
  • Line 74: Replace throw Error() with throw new Error().

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  • Line 9: Remove the extra comma at the end of the 'ChannelInfoOptions' type definition.
  • Line 12: Fix the typo in the 'SubscribeUnsubscribeOptions' type definition from 'settings?: UserSetting[]' to 'setting?: UserSetting[]'.
  • Line 23: Remove the extra comma at the end of the 'FeedsOptions' type definition.
  • Line 26: Remove the line comment '// Types related to notification'.
  • Line 56: Remove the extra comma at the end of the 'IPayload' type definition.

File: packages/restapi/src/lib/pushNotification/channel.ts

  • Line 32: Add a missing closing parenthesis ')' after the function parameter name 'error'.
  • Line 37: Add a missing closing parenthesis ')' after the function parameter name 'error'.
  • Line 47: Remove the closing parenthesis ')' after the 'if' statement condition.
  • Line 49: Remove the closing parenthesis ')' after the 'if' statement condition.
  • Line 59: Fix the typo in the function name from '_getSubscribers' to 'getSubscribers'.
  • Line 60: Add a missing closing parenthesis ')' after the function parameter name 'error'.

File: packages/restapi/tests/lib/notification/channel.test.ts

  • Line 51: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 54: Remove the line comment '// console.log(res);'.
  • Line 61: Remove the line comment '// const res = await userBob.channel.search('')'.
  • Line 69: Add a missing closing parenthesis ')' after the function parameter name '()'.
  • Line 72: Add a missing closing parenthesis ')' after the function parameter name '()'.
  • Line 88: Add a missing opening parenthesis '(' before the 'to.Throw' function call.
  • Line 95: Add a missing closing parenthesis ')' after the function parameter name '()'.
  • Line 105: Add a missing opening curly brace '{' before the return statement.
  • Line 106: Add a missing closing curly brace '}' after the return statement.
  • Line 110: Add a missing closing parenthesis ')' after the function parameter name 'error'.
  • Line 123: Add a missing closing parenthesis ')' after the function parameter name 'error'.
  • Line 135: Add a missing closing parenthesis ')' after the function parameter name 'error'.
  • Line 144: Add a missing closing parenthesis ')' after the function parameter name 'recipients'.
  • Line 153: Add a missing closing parenthesis ')' after the function parameter name 'recipients'.
  • Line 171: Remove the line comment '// console.log(res)'.
  • Line 174: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 179: Add a missing opening curly brace '{' before the return statement.
  • Line 180: Add a missing closing curly brace '}' after the return statement.
  • Line 184: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 191: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 194: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 201: Remove the line comment '// console.log(res)'.
  • Line 208: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 215: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 220: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 229: Add a missing closing parenthesis ')' after the function parameter name 'res'.
  • Line 231: Add a missing closing parenthesis ')' after the function parameter name 'error'.

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

  • No changes needed. All looks good.

Copy link

File: packages/restapi/src/lib/channels/getSubscribers.ts

  1. Line 9: There is a typo in the import statement. It should be Subscribers instead of ResourceLimits.

  2. Line 26: There is a missing closing brace '}' after the error message for page must be greater than 0.

  3. Line 28: There is a missing closing brace '}' after the error message for limit must be greater than 0.

  4. Line 30: There is a missing closing brace '}' after the error message for limit must be lesser than or equal to 30.

  5. Line 33: There is a missing closing brace '}' after the error message for channel cannot be null or empty.

  6. Line 40: There is a missing closing brace '}' after the if statement for checking if category exists.

  7. Line 41: There is a missing closing brace '}' after the if statement for checking if category exists.

  8. Line 42: There is a missing closing brace '}' after the if statement for checking if category exists.

  9. Line 45: There is a missing closing brace '}' after the if statement for checking if category exists.

  10. Line 47: There is a missing closing brace '}' after the if statement for checking if category exists.

  11. Line 52: There is a missing closing parenthesis ')' after the condition for the if statement that checks if category exists.

  12. Line 53: There is a missing closing brace '}' after the if statement for checking if category exists.

  13. Line 61: There is a missing closing parenthesis ')' after the function call to getAPIBaseUrls(env).

  14. Line 72: There is a missing closing parenthesis ')' after the concatenation of apiEndpoint and '&category=${category}'.

  15. Line 86: There is an extra closing parenthesis ')' after the catch block.

  16. Line 89: There is a missing closing brace '}' after the catch block.

File: packages/restapi/tests/lib/notification/channel.test.ts

  1. Line 123: There is a missing closing parenthesis ')' after the expect statement.

  2. Line 127: There is a missing closing parenthesis ')' after the expect statement.

  3. Line 149: There is a missing closing parenthesis ')' after the expect statement.

  4. Line 159: There is a missing closing parenthesis ')' after the expect statement.

  5. Line 163: There is a missing closing parenthesis ')' after the expect statement.

  6. Line 173: There is a missing closing parenthesis ')' after the expect statement.

  7. Line 180: There is a missing closing parenthesis ')' after the expect statement.

  8. Line 193: There is a missing closing parenthesis ')' after the expect statement.

  9. Line 204: There is a missing closing parenthesis ')' after the expect statement.

  10. Line 214: There is a missing closing parenthesis ')' after the expect statement.

  11. Line 219: There is a missing closing parenthesis ')' after the expect statement.

  12. Line 231: There is a missing closing parenthesis ')' after the expect statement.

  13. Line 244: There is a missing closing parenthesis ')' after the expect statement.

  14. Line 253: There is a missing closing parenthesis ')' after the expect statement.

  15. Line 263: There is a missing closing parenthesis ')' after the expect statement.

  16. Line 274: There is a missing closing parenthesis ')' after the expect statement.

  17. Line 293: There is a missing closing parenthesis ')' after the expect statement.

  18. Line 313: There is a missing closing parenthesis ')' after the expect statement.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 6df8a6f into main Nov 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants