Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: participant high level functions #896

Conversation

mohammeds1992
Copy link
Collaborator

No description provided.

Copy link

File: packages/restapi/src/lib/chat/getGroupMembers.ts

  • In the getGroupMembers function, there is a missing closing bracket for the if (pending !== undefined) condition. Please add the closing bracket } at the end of line 25.
  • In the catch block of the try-catch statement, there is a missing closing bracket } at the end of line 41. Please add the closing bracket.
  • All looks good.

File: packages/restapi/src/lib/pushapi/chat.ts

  • There is a missing import statement for the PushChat.createGroupV2 function from the pushAPITypes module. Please add import * as PushChat from './pushAPITypes'; at line 16.
  • In the list function, the type declaration for the type parameter should be ChatListType instead of ${ChatListType}. Please change type: ${ChatListType}`` to type: ChatListType at line 49.
  • In the create function, there is a missing closing bracket } at the end of line 82. Please add the closing bracket.
  • In the participants object, the list function is missing a closing bracket } at the end of line 86. Please add the closing bracket.
  • In the participants object, the count function is missing a closing bracket } at the end of line 95. Please add the closing bracket.
  • In the participants object, the status function is missing a closing bracket } at the end of line 103. Please add the closing bracket.
  • All looks good.

File: packages/restapi/src/lib/pushapi/pushAPITypes.ts

  • In the GetGroupParticipantsOptions interface, there is a missing closing bracket } at the end of line 39. Please add the closing bracket.
  • All looks good.

File: packages/restapi/src/lib/types/index.ts

  • All looks good.

File: packages/restapi/tests/lib/notification/base.test.ts

  • In the ENV enum, there is a missing closing bracket } at the end of line 37. Please add the closing bracket.
  • In the describe block, there are several commented out lines of code. Please remove the commented lines to clean up the code.
  • All looks good.

@mohammeds1992 mohammeds1992 merged commit 645d564 into main Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

😈 [Improvement Proposal] - Add userAlice.chat.participants.status high level function
2 participants