Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range type noif #886

Merged
merged 473 commits into from
Nov 27, 2023
Merged

Range type noif #886

merged 473 commits into from
Nov 27, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Nov 27, 2023

No description provided.

mohammeds1992 and others added 23 commits October 4, 2023 17:04
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  • Typo: "body" in type INotification should be optional. Should be "body?: string;"

File: packages/restapi/src/lib/pushNotification/channel.ts

  • Typo: In the send method, there is a missing closing parenthesis after "settings = JSON.parse(info.channel_settings);"

  • Typo: In the send method, the line "throw new Error(Push SDK Error: API : channel::send : ${error});" is outside of the catch block and should be moved inside the catch block.

  • Typo: In the create method, there is a missing closing parenthesis after "throw new Error('viem signer is not provided');"

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  • Typo: "LENGTH_LOWER_LIMTI" should be "LENGTH_LOWER_LIMIT"

  • Typo: "iphfs" in IAdvance should be "ipfs"

  • Typo: "imony" in createContractInstance should be "in"

  • Typo: "BROADCA" in FEED_MAP should be "BROADCAST"

  • Mistake: The createPublicClient, http, getContract, and WalletClient imports from 'viem' are not used and can be removed.

File: packages/restapi/tests/lib/pushNotification/base.test.ts

  • The file is empty, no code to review.

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

  • The file is empty, no code to review.

All looks good.

Copy link

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  1. In line 9, there is a missing closing brace } for the ChannelInfoOptions type.

  2. In line 12, there is a missing closing brace } for the SubscribeUnsubscribeOptions type.

  3. In line 15, there is a missing closing brace } for the UserSetting type.

  4. In line 19, there is a missing closing brace } for the FeedsOptions type.

  5. In line 22, there is a missing closing brace } for the ChannelSearchOptions type.

  6. In line 27, there is a missing closing brace } for the NotificationOptions type.

  7. In line 33, there is a missing closing brace } for the CreateChannelOptions type.

  8. In line 40, there is a missing closing brace } for the NotificationSetting type.

  9. In line 43, there is a missing closing brace } for the NotificationSettings type.

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  1. In line 121, there is an unnecessary comma , after the getContract import statement.

  2. In line 131, there is an unnecessary comma , after the validateCAIP import statement.

  3. In line 149, there is an unnecessary comma , after the getFallbackETHCAIPAddress import statement.

  4. In line 172, there is an unnecessary comma , after the PushAPI import statement.

  5. In line 190, there is an unnecessary comma , after the axios import statement.

  6. In line 202, there is an unnecessary comma , after the Chain import statement.

  7. In line 216, there is an unnecessary comma , after the getAPIBaseUrls import statement.

  8. In line 227, there is an unnecessary comma , after the PUSH_ALIAS import statement.

  9. In line 245, there is an unnecessary comma , after the PUSH_CHANNEL import statement.

  10. In line 261, there is an unnecessary comma , after the BigNumber import statement.

  11. In line 263, there is an unnecessary comma , after the ethers import statement.

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

  1. In line 53 and line 67, there are repeated properties category in the object literal.

  2. In line 70 and line 74, there are incorrect keys assigned to the properties title and body respectively.

All looks good.

@akp111 akp111 changed the base branch from main to alpha November 27, 2023 12:24
@akp111 akp111 changed the base branch from alpha to main November 27, 2023 12:50
@mohammeds1992 mohammeds1992 merged commit 73f3e9c into main Nov 27, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants