Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix depreaction warn of get subscribers using pagination #864

Merged
merged 1 commit into from
Nov 22, 2023

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Nov 22, 2023

No description provided.

@Aman035 Aman035 linked an issue Nov 22, 2023 that may be closed by this pull request
Copy link

File: packages/restapi/README.md

  • In the "Search Channels" section, the table formatting is incorrect. The pipe symbol (|) is missing at the beginning and end of the table headers.
  • In the "Search Channels" section, the method signature is missing the "async" keyword.
  • In the "Get Subscribers Of A Channel" section, the table formatting is incorrect. The pipe symbol (|) is missing at the beginning and end of the table headers.
  • In the "Get Subscribers Of A Channel" section, the method signature is missing the "async" keyword.
  • In the "Send a notification" section, the table formatting is incorrect. The pipe symbol (|) is missing at the beginning and end of the table headers.
  • In the "Send a notification" section, the method signature is missing the "async" keyword.

File: packages/restapi/src/lib/channels/_getSubscribers.ts

  • The import statement for Constants is missing the file extension (.ts).

File: packages/restapi/src/lib/pushNotification/PushNotificationTypes.ts

  • The import statement for ADDITIONAL_META_TYPE is missing the file path.

File: packages/restapi/src/lib/pushNotification/channel.ts

  • The code block for the "search" method is missing two closing brackets at the end.
  • The code block for the "subscribers" method is missing two closing brackets at the end.
  • The code block for the "send" method is missing two closing brackets at the end.
  • The code block for the "create" method is missing one closing bracket at the end.

All other code and documentation looks good.

@Aman035 Aman035 merged commit c9b7f9e into main Nov 22, 2023
1 check passed
@Aman035 Aman035 deleted the fix-get-subscribers branch November 22, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - Deprecation Warn from channel.subscribers
2 participants