Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rn chat requests #835

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Rn chat requests #835

merged 12 commits into from
Jan 5, 2024

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Nov 14, 2023

No description provided.

Copy link

File: packages/reactnative/example/package.json

  • In line 19, there is a missing closing curly brace (}) for the "dependencies" object.

All looks good.

File: packages/reactnative/example/src/App.tsx

  • In line 19, the import statement for "OpenPGP" is not terminated with a semicolon (;).
  • In line 52, the handleProfileUpgrade function is missing a closing curly brace (}).
  • In line 67, the handleInbox function is missing a closing curly brace (}).
  • In line 71, the handleSend function is missing a closing curly brace (}).
  • In line 75, the handleApproveRequest function is missing a closing curly brace (}).

All looks good.

File: packages/reactnative/package.json

  • In line 102, there is a missing closing curly brace (}) for the "scripts" object.
  • In line 104, there is a missing closing square bracket (]) for the "keywords" array.
  • In line 106, there is a missing closing curly brace (}) for the "repository" object.
  • In line 108, there is a missing closing curly brace (}) for the "bugs" object.
  • In line 110, there is a missing closing curly brace (}) for the "homepage" object.
  • In line 112, there is a missing closing curly brace (}) for the "publishConfig" object.
  • In line 114, there is a missing closing curly brace (}) for the "dependencies" object.
  • In line 188, there is a missing closing curly brace (}) for the "devDependencies" object.
  • In line 201, there is a missing closing curly brace (}) for the "resolutions" object.
  • In line 218, there is a missing closing curly brace (}) for the "peerDependencies" object.

All looks good.

File: packages/restapi/src/lib/chat/chat.ts

  • In line 77, there is a missing closing parenthesis ()) for the "profileUpgrade" function call.
  • In line 80, there is a missing closing curly brace (}) for the

Copy link
Member

@Aman035 Aman035 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DecryptAndVerifySignature failing, IPgpHelper should be passed as default

image

@kalashshah
Copy link
Contributor

kalashshah commented Nov 21, 2023

DecryptAndVerifySignature failing, IPgpHelper should be passed as default

image

@Aman035 Fixed this, pgpHelper passed as default to the decryptAndVerifyMessage function

@kalashshah kalashshah requested a review from Aman035 November 21, 2023 09:18
@kalashshah kalashshah requested a review from Aman035 January 4, 2024 07:53
@kalashshah kalashshah self-assigned this Jan 4, 2024
@Aman035 Aman035 merged commit 28a03d8 into main Jan 5, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants