Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed balance check #818

Merged
merged 470 commits into from
Nov 6, 2023
Merged

Fixed balance check #818

merged 470 commits into from
Nov 6, 2023

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Nov 6, 2023

No description provided.

Aman035 and others added 22 commits October 3, 2023 13:36
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer (#736)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

---------

Co-authored-by: Nilesh Gupta <[email protected]>
* Arbitrum changes (#735)

* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes

* fix: minor fixes

* fix: fixed typo

* fix: notification settings related changes

* fix: added index parameter for notification
* refactor: added code for joining livekit room for listeners (#731)

* feat: drop in livekit inplace of livepeer

* feat: added microphone

* feat: added mic

* feat: added access control

* feat: fixes for livekit API call

---------

Co-authored-by: Nilesh Gupta <[email protected]>
Copy link

github-actions bot commented Nov 6, 2023

File: packages/restapi/src/lib/pushNotification/channel.ts

  • In the create method, there's a typo in the error message. Change throw new Error('viem signer is not provided'); to throw new Error('viem signer is not provided');.
  • In the create method, there's an unclosed parenthesis in the following line: ethers.utils.parseUnits(config.MIN_TOKEN_BALANCE[this.env!].toString(), 18. Add a closing parenthesis at the end of the line.
  • In the create method, there's a missing closing parenthesis at the end of the config.MIN_TOKEN_BALANCE[this.env!].toString(). Add a closing parenthesis at the end of the line.
  • In the create method, there's a missing closing parenthesis at the end of the const allowanceAmount = await this.fetchAllownace(pushTokenContract, this.account!, config.CORE_CONFIG[this.env!].EPNS_CORE_CONTRACT. Add a closing parenthesis at the end of the line.
  • In the create method, there's no closing parenthesis for the if (!approvalRes) { block. Add a closing parenthesis at the end of the block.
  • In the create method, there's an unclosed parenthesis in the following line: const allowanceAmount = await this.fetchAllownace(pushTokenContract, this.account!, config.CORE_CONFIG[this.env!].EPNS_CORE_CONTRACT. Add a closing parenthesis at the end of the line.
  • In the update method, there's a missing closing parenthesis at the end of the const totalFees = fees.mul(counter). Add a closing parenthesis at the end of the line.
  • In the update method, there's a missing closing parenthesis at the end of the if (!totalFees.gte(balance)) { block. Add a closing parenthesis at the end of the block.
  • In the update method, there's an unclosed parenthesis in the following line: if (!allowanceAmount.gte(totalFees)) {. Add a closing parenthesis at the end of the line.
  • In the update method, there's no closing parenthesis for the if (!allowanceAmount.gte(totalFees)) { block. Add a closing parenthesis at the end of the block.
  • In the update method, there's a missing closing parenthesis at the end of the progressHook?.(PROGRESSHOOK['PUSH-UPDATE-02'] as ProgressHookType); line. Add a closing parenthesis at the end of the line.
  • In the update method, there's an unclosed parenthesis in the following line: if (!res) {. Add a closing parenthesis at the end of the line.
  • In the update method, there's no closing parenthesis for the if (!res) { block. Add a closing parenthesis at the end of the block.
  • In the setting method, there's an unclosed parenthesis in the following line: const approveRes = await this.approveToken(. Add a closing parenthesis at the end of the line.
  • In the setting method, there's no closing parenthesis for the if (!approveRes) { block. Add a closing parenthesis at the end of the block.

File: packages/restapi/src/lib/pushNotification/pushNotificationBase.ts

  • In the checkProvider method, there's an unnecessary closing parenthesis at the end of the return chainId; line. Remove the closing parenthesis.

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

  • In the channel :: create test, remove the .only to enable running all tests instead of running just this one.

All looks good.

Copy link

github-actions bot commented Nov 6, 2023

File: packages/restapi/src/lib/pushNotification/channel.ts

  • Line 25: The word "viem" should be "view".
  • Line 39: There is a missing closing parenthesis ")" on this line.
  • Line 55: There is a missing closing parenthesis ")" on this line.
  • Line 59: There is a missing closing parenthesis ")" on this line.
  • Line 67: There is a missing closing parenthesis ")" on this line.
  • Line 111: There is a missing closing parenthesis ")" on this line.
  • Line 125: There is a missing closing parenthesis ")" on this line.

File: packages/restapi/tests/lib/pushNotification/channel.test.ts

  • Line 51: There is an incomplete describe block on this line. It should have a closing parenthesis ")" and a closing brace "}".
  • Line 71: There is an incomplete describe block on this line. It should have a closing parenthesis ")" and a closing brace "}".

All other code appears to be fine.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 8e61f6b into main Nov 6, 2023
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants