Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: group info loading done #793

Merged
merged 4 commits into from
Oct 18, 2023
Merged

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Oct 18, 2023

No description provided.

@github-actions
Copy link

In ChatProfile.tsx:

  1. Line 85: There is a missing closing parenthesis for the ImageItem component.
<ImageItem onClick={() => setOptions(true)}>
            src={VerticalEllipsisIcon}
            height="21px"
            maxHeight="32px"
            cursor="pointer"
          {options && (

Should be:

<ImageItem onClick={() => setOptions(true)}>
            src={VerticalEllipsisIcon}
            height="21px"
            maxHeight="32px"
            cursor="pointer"
          >
          {options && (
  1. Line 187: The closing } for the ChatProfile functional component is missing.
else {

Should be:

} else {

In GroupInfoModal.tsx:

  1. Line 13: The import statement for Tooltip is missing.
import { useEffect, useRef, useState, Tooltip } from 'react';
  1. Line 91: The closing } for the handlePreviousInfo function is missing.
const handlePreviousInfo = () => {
    setActiveComponent((activeComponent - 1) as GROUP_INFO_TYPE);

Should be:

const handlePreviousInfo = () => {
    setActiveComponent((activeComponent - 1) as GROUP_INFO_TYPE);
  }
  1. Line 184: The closing } for the GroupTypeProps interface is missing.
const GroupTypeBadge = ({
  icon,
  header,
  subheader,
  handleNextInformation,

Should be:

const GroupTypeBadge = ({
  icon,
  header,
  subheader,
  handleNextInformation,
}) => {
  1. Line 201: The closing } for the renderComponent function is missing.
renderComponent();

Should be:

return renderComponent();
  1. Line 210: The <div> element is missing a closing tag.
{Object.keys(ACCESS_TYPE_TITLE).map((key, idx) => (
        <div key={idx}>

Should be:

{Object.keys(ACCESS_TYPE_TITLE).map((key, idx) => (
        <div key={idx}>
        ...
        </div>
  1. Line 263: The closing } for the handleClose function is missing.
const handleClose = () => onClose();

Should be:

const handleClose = () => {
    onClose();
  };
  1. Line 314: The closing } for the onClose function is missing.
onClose();

Should be:

onClose();
  };

In AddCriteria.tsx:

  1. Line 57-60: The object literal syntax for the ERC721 property is incorrect.
ERC721:{
INVITE: {
  value: SUBCATEGORY.DEFAULT,
  title: 'Default',
CustomEndpoint: [
    id: 0,
    value: SUBCATEGORY.GET,
    title: 'Get',
    function: () => setSelectedSubCategoryValue(0),

Should be:

ERC721: {
  value: SUBCATEGORY.HOLDER,
  title: 'Holder',
},
INVITE: {
  value: SUBCATEGORY.DEFAULT,
  title: 'Default',
},
CustomEndpoint: [
  {
    id: 0,
    value: SUBCATEGORY.GET,
    title: 'Get',
    function: () => setSelectedSubCategoryValue(0),
  },
],
  1. Line 69: The : is missing after the ROLES key.
ROLES: {

Should be:

ROLES: {
  value: SUBCATEGORY.DEFAULT,
  title: 'Default',
},
  1. Line 84-87: The closing } for the dropdownChainsValues array is missing.
const dropdownChainsValues: Array<DropdownValueType> = [

Should be:

const dropdownChainsValues: Array<DropdownValueType> = [
  {
    id: 0,
    value: 'eip155:1',
    title: 'Ethereum',
  },
  // Add other chain values here
];
  1. Line 127: The } for the onQuantityChange function is missing.
setQuantity({ ...quantity, value: e.target.value });

Should be:

setQuantity({ ...quantity, value: e.target.value });
};
  1. Line 129: The } for the verifyAndDoNext function is missing.
setValidationLoading

@github-actions
Copy link

All looks good.

@mishramonalisha76 mishramonalisha76 merged commit 27d782d into gated-group-info Oct 18, 2023
1 check passed
@github-actions
Copy link

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

  • The import statement for ChatViewComponent from @pushprotocol/uiweb is unnecessary since it is already the file being exported in the export default statement at the end. You can remove this import statement.
  • The closing tag for the ImageItem component is missing in the code. Add </ImageItem> after the </TextItem> closing tag.
  • The GroupInfoModal component is not imported in this file. You need to import it using the following statement: import { GroupInfoModal } from "@pushprotocol/uiweb";

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

  • The isMobile variable is defined but not used in this file. You can remove it.
  • The getSubCategoryDropdownValues function is missing a closing bracket. Add a closing bracket } at the end of the function.
  • The verifyAndDoNext function is missing a closing bracket. Add a closing bracket } at the end of the function.

File: packages/uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx

  • The dropdownChainsValues array is defined but not used in this file. You can remove it.
  • The dropdownSubCategoryValues object is missing a closing bracket. Add a closing bracket } at the end of the object.

File: packages/uiweb/src/lib/components/chat/helpers/getRulesToCondtionArray.ts

  • The getKey function is missing a closing bracket. Add a closing bracket } at the end of the function.
  • The getRulesToCondtionArray function is missing a closing bracket. Add a closing bracket } at the end of the function.

File: packages/uiweb/src/lib/hooks/index.ts

  • The import statement for useTokenSymbolLoader is unnecessary since it is not used in this file. You can remove this import statement.

All looks good.

mohammeds1992 pushed a commit that referenced this pull request Oct 18, 2023
* fix: uncommented group info

* fix: fixed image size and group type text (#790)

* feat: changed styled-components version and changed header and sub header in type of group (#788)

* fix: fixed lint issues in chat (#784)

* feat: changed styled-components version

* fix: changed header and subheader as per the instructions

---------

Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* fix: adde chat id in group info

* fix: added click to copy

* feat: group info loading done (#793)

* feat: group info loading done

* feat: logs cleared

* fix: fixed minor issues

---------

Co-authored-by: Monalisha Mishra <[email protected]>

---------

Co-authored-by: Satyam <[email protected]>
Co-authored-by: Abishek Bashyal <[email protected]>
mohammeds1992 pushed a commit that referenced this pull request Oct 19, 2023
* fix: uncommented group info

* fix: fixed image size and group type text (#790)

* feat: changed styled-components version and changed header and sub header in type of group (#788)

* fix: fixed lint issues in chat (#784)

* feat: changed styled-components version

* fix: changed header and subheader as per the instructions

---------

Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* fix: adde chat id in group info

* fix: added click to copy

* feat: group info loading done (#793)

* feat: group info loading done

* feat: logs cleared

* fix: fixed minor issues

---------

Co-authored-by: Monalisha Mishra <[email protected]>

* fix: fixed build issues

---------

Co-authored-by: Satyam <[email protected]>
Co-authored-by: Abishek Bashyal <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants