Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Group criteria states #750

Merged
merged 23 commits into from
Oct 5, 2023
Merged

Group criteria states #750

merged 23 commits into from
Oct 5, 2023

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Oct 4, 2023

No description provided.

akp111 and others added 13 commits September 29, 2023 14:14
@akp111
Arbitrum changes (#735)
23fa1bc 
* fix: inital implementation for arbitrum changes

* fix: more changes

* fix: added final changes
@MdTeach
feat: condition type added
91f3723
@MdTeach
feat: adder done
30404ab
@MdTeach
feat: all/any added on condition box
a9908f9
@akp111
fix: minor fixes
6737403
@akp111
fix: fixed typo
3c6b14d
@akp111
Merge pull request #745 from ethereum-push-notification-service/minor…
207009e 
…-fixes-arb

fix: minor fixes
@Aman035
docs: added Class Examples (#739)
a4da132 
* docs: added documentation

* docs: fixed chat class examples

* docs: fix notif class

* docs: fixed stream examples

* docs: fix nft grp update

* docs: fixed logs
@Aman035
Message Type Implementations (#730)
e86b846 
* fix: added video & audio messages

* fix: fixed meta, reaction & added intent & readReceipt

* fix: added reply

* fix: added composite, fixed receipt
@strykerin
fix: local tests (#744)
e6ac9dc
@rahulpandey70
fix(env and index): fixes typo RECIPEINT to RECIPIENT (#743)
6cc4db3 
fix #733
@dinesh11515
Update README.md (#742)
ef50b45 
Changed the discord link
@MdTeach
feat: add criteria done
9fb2f12
@MdTeach MdTeach marked this pull request as ready for review October 4, 2023 12:22
@github-actions
Copy link

github-actions bot commented Oct 4, 2023

In file packages/uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx:

  1. Line 55: There is an extra closing parenthesis after the assignment of selectedSubCategoryValue.

  2. Line 57: There is a missing closing parenthesis after the assignment of selectedChainValue.

  3. Line 70: The second argument of the useState hook setInviteCheckboxes is missing a closing parenthesis.

  4. Line 72: There is an extra closing parenthesis after the object assignment of inviterRoles.

  5. Line 75: There is a missing closing parenthesis after the object assignment of url.

  6. Line 82: There is a missing closing parenthesis after the object assignment of role.

  7. Line 86: There is an extra closing parenthesis after the object assignment of comparison.

  8. Line 119: There is an extra closing parenthesis after the alert statement.

  9. Line 135: There is a missing closing parenthesis after the handlePrevious function call.

  10. Line 169: There is a missing closing parenthesis after the closing tag of the GUILD_COMPARISON_OPTIONS mapping.

  11. Line 198: There is a missing closing parenthesis after the closing tag of the Button component.

  12. Line 223: There is an extra closing curly brace after the closing tag of the GatingRulesInformation component.

  13. Line 253: There is a missing closing parenthesis after the closing tag of the MoreOptionsContainer component.

In file packages/uiweb/src/lib/components/chat/CreateGroup/ConditionsComponent.tsx:

  1. Line 123: There is an extra opening curly brace after the if statement checking if deleteFunction exists.

  2. Line 146: There is a missing closing parenthesis after the assignment of the id property.

All looks good.

@github-actions
Copy link

github-actions bot commented Oct 4, 2023

File: README.md

All looks good.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

File: README.md

All looks good.

File: packages/examples/sdk-backend-node/.env.sample

All looks good.

File: packages/examples/sdk-backend-node/chat/nftChat.ts

  • Line 61: Typo in the comment, "pgpDecrpyptedPvtKey" should be "pgpDecryptedPvtKey".
  • Line 69: Typo in the comment, "admins: [nftAccount1]," should be "admins: [nftAccount1],".

File: packages/examples/sdk-backend-node/package.json

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/channel.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/chat.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/encryption.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/index.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/notification.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/profile.ts

All looks good.

File: packages/examples/sdk-backend-node/pushAPI/stream.ts

All looks good.

File: packages/examples/sdk-backend-node/video/index.ts

All looks good.

File: packages/examples/sdk-frontend-react/src/app/components/Connect.tsx

All looks good.

File: packages/examples/sdk-frontend-react/src/app/helpers.ts

mishramonalisha76
mishramonalisha76 requested changes Oct 5, 2023
View reviewed changes
Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Delete criteria, singleCriteria and multiple criteria , method

packages/uiweb/src/lib/components/chat/CreateGroup/AddCriteria.tsx Show resolved Hide resolved
packages/uiweb/src/lib/components/chat/CreateGroup/CreateGroupType.tsx Show resolved Hide resolved
packages/uiweb/src/lib/components/chat/CreateGroup/DefineCondition.tsx Show resolved Hide resolved
packages/uiweb/src/lib/components/chat/CreateGroup/DefineCondition.tsx Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

All looks good.

@github-actions
Copy link

github-actions bot commented Oct 5, 2023

All looks good.

@MdTeach MdTeach merged commit 47016bc into group-criteria Oct 5, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mishramonalisha76 mishramonalisha76 mishramonalisha76 requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@MdTeach @mishramonalisha76 @akp111 @Aman035 @strykerin @rahulpandey70 @dinesh11515