feat: added icon in groupinfo to show if it is token gated or not #748

KlausMikhaelson · 2023-10-04T02:49:20Z

No description provided.

github-actions · 2023-10-04T02:49:39Z

All looks good.

github-actions · 2023-10-04T08:29:23Z

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

The import statement for the ChatViewComponent from @pushprotocol/uiweb is incorrect. It should be:

import { ChatViewComponent } from "@pushprotocol/uiweb";

The declaration of ChatViewComponentCard component is missing. It should be defined using the styled function from styled-components:

const ChatViewComponentCard = styled(Section)`
  height: 60vh;
`;

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

The type declaration for the OptionProps is incorrect. It should import IChatTheme from ../theme/ThemeProvider and the groupInfo property should be optional:

import { IChatTheme } from '../theme/ThemeProvider';

type OptionProps = {
  options: boolean;
  setOptions: React.Dispatch<React.SetStateAction<boolean>>;
  isGroup: boolean;
  groupInfo?: IGroup | null | undefined;
  setGroupInfo: React.Dispatch<React.SetStateAction<IGroup | null | undefined>>;
  theme: IChatTheme;
};

The closing parenthesis for the ImageItem component is missing. It should be added before the onClick prop:

<ImageItem onClick={() => setOptions(true)}>

The opening and closing parentheses for the ImageItem component before the onClick prop are misplaced. It should be moved to enclose the entire component block.
The GroupInfoModal component is not imported. It should be imported from the correct location:

import { GroupInfoModal } from './GroupInfoModal';

The closing parentheses for the ShowModal function are missing. It should be added after the closing brace:

const ShowModal = () => {
    setModal(true);
  };

The fetchProfileData function is missing a closing brace at the end.
The getImage function is missing a closing brace and a return statement at the end.
The getProfileName function is missing a closing brace at the end.
The ChatProfile component is missing a closing parentheses for the function definition.

File: packages/uiweb/src/lib/components/chat/ChatProfile/GroupInfoModal.tsx

The file is empty and needs to be implemented.

Overall, the code has several import statement and syntax errors that need to be fixed.

github-actions · 2023-10-05T05:54:44Z

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatProfile.tsx

The ChatProfileTest component is not being used anywhere. It can be removed.

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

The ChatViewComponentTest component is not being used anywhere. It can be removed.

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

The imports for styled-components, IUser, ethers, ToastContainer, Image, Section, `

mishramonalisha76

Remove unused and console logs
Arrange imports

mishramonalisha76 · 2023-10-05T07:28:15Z

packages/uiweb/src/lib/components/chat/ChatProfile/GroupInfoModal.tsx

 type GroupInfoModalProps = {
  theme: IChatTheme;
  setModal: React.Dispatch<React.SetStateAction<boolean>>;
  groupInfo: IGroup;
  setGroupInfo: React.Dispatch<React.SetStateAction<IGroup | null | undefined>>;
+  handleNextInformation: () => void;


type GroupInfoModalProps = {
theme: IChatTheme;
setModal: React.Dispatch<React.SetStateAction>;
groupInfo: IGroup;
setGroupInfo: React.Dispatch<React.SetStateAction<IGroup | null | undefined>>;
};

type GroupSectionsProps = GroupInfoModalProps & {
handleNextInformation: () => void;
handlePreviousInformation: () => void;
};
And use in the respective components

mishramonalisha76 · 2023-10-05T07:16:11Z

packages/uiweb/src/lib/components/chat/ChatProfile/GroupInfoModal.tsx

+      <PublicEncrypted theme={theme}>
+        <Image
+          src={groupInfo?.isPublic ? LockIcon : LockSlashIcon}
+          height="24px"
+          maxHeight="24px"
+          width={'auto'}
+        />
+
+        <Section flexDirection="column" alignItems="flex-start" gap="5px">
+          <Span fontSize="18px" color={theme.textColor?.modalHeadingText}>
+            {groupInfo?.isPublic ? 'Open' : 'Encrypted'}
+          </Span>
+          <Span
+            fontSize="12px"
+            color={theme.textColor?.modalSubHeadingText}
+          >
+            {groupInfo?.isPublic
+              ? 'Chats are not encrypted'
+              : 'Chats are end-to-end encrypted'}
+          </Span>
+        </Section>
+      </PublicEncrypted>


this entire thing can be reused for the gated section too, so create a reusable component for this

mishramonalisha76 · 2023-10-05T08:02:13Z

packages/uiweb/src/lib/components/chat/ChatProfile/GroupInfoModal.tsx

+    });
+  };
+
+  const addMembers = async () => {


Remove the unused methods

mishramonalisha76 · 2023-10-05T08:04:48Z

packages/uiweb/src/lib/components/chat/ChatProfile/GroupInfoModal.tsx

+      <Section margin='0px 0px 15px 0px'>
+      {
+        (groupInfo?.rules?.chat?.conditions || groupInfo?.rules?.entry?.conditions) && (
+          <PublicEncrypted theme={theme}>


the GateGroup section can be reused same as groupInformation component

this is not there

KlausMikhaelson · 2023-10-06T07:00:14Z

@mishramonalisha76 have made the changes as per the comments!

github-actions · 2023-10-06T09:13:01Z

File: .husky/pre-commit

#!/bin/sh
. "$(dirname "$0")/_/husky.sh"

echo "\nRunning GIT hooks..."
yarn cleanbuild
yarn nx affected --target=lint
yarn nx affected --target=test

All looks good.

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatProfile.tsx

There are three different chatId values commented out. Remove the unnecessary ones and keep the correct one.

File: packages/examples/sdk-frontend-react/src/app/ChatUITest/ChatViewComponent.tsx

All looks good.

File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx

The code is missing a closing curly brace '}' for the 'fetchProfileData' function at the end of the component. Add the closing brace before the 'getImage' function.
The 'getImage' function has an unreachable return statement. Remove the duplicate return statement in the function.
The 'getProfileName' function is missing a closing curly brace '}' before the 'useEffect' hook. Add the closing brace after the last line of the function.
The 'useEffect' hook is missing a closing curly brace '}' after the dependency array. Add the closing brace after the last line of the hook.
The JSX code starting with <Container is missing a closing tag. Add </Container> before the last line of the component.

File: packages/uiweb/src/lib/components/chat/GroupInfoModal.tsx