Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add counter for update channel #741

Merged
merged 4 commits into from
Sep 29, 2023
Merged

Conversation

akp111
Copy link
Collaborator

@akp111 akp111 commented Sep 29, 2023

No description provided.

@github-actions
Copy link

In packages/restapi/src/lib/pushNotification/channel.ts:

  1. There is an extra closing curly brace '}' after the import statement for Alias.
  2. There is a typo in the comment for the info method, 'serach' should be 'search'.
  3. In the search method, the object destructuring for options is missing a comma after the limit property.
  4. There is an unnecessary catch block after the return statement in the info method.
  5. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write.
  6. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the throw statement.
  7. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the final throw statement.
  8. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the balance variable assignment.
  9. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the fees variable assignment.
  10. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the allowanceAmount variable assignment.
  11. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the allowanceRes variable assignment.
  12. In the update method, there is a missing closing parenthesis after the condition check for the existence of this.coreContract.write in the updateChannelRes variable assignment.

In packages/restapi/src/lib/pushNotification/pushNotificationBase.ts:

  1. In the fetchBalance method, there is a missing closing parenthesis after the condition check for the existence of this.signer.provider in the first throw statement.
  2. In the fetchBalance method, there is a missing closing parenthesis after the condition check for the existence of this.signer.provider in the second throw statement.
  3. In the fetchAllownace method, there is a missing closing parenthesis after the assignment statement for allowanceInBigInt.
  4. In the fetchUpdateCounter method, there is a missing closing parenthesis after the assignment statement for countInBigInt.
  5. In the approveToken method, there is a missing closing parenthesis after the condition check for the existence of this.signer.provider in the first throw statement.
  6. In the approveToken method, there is a missing closing parenthesis after the assignment statement for approvalTrxPromise.
  7. In the approveToken method, there is a missing closing parenthesis after the assignment statement for approvalTrxRes.
  8. In the approveToken method, there is an extra closing curly brace '}' after the second throw statement.
  9. In the approveToken method, there is an extra closing curly brace '}' after the return false statement.
  10. In the createChannel method, there is an unnecessary await keyword before the uploadToIPFSViaPushNode method call.
  11. In the createChannel method, there is a missing closing parenthesis after the uploadToIPFSViaPushNode method call.

In packages/restapi/src/lib/pushapi/PushAPI.ts:

  1. There is an extra closing parenthesis after the env parameter in the constructor.

Everything else looks good.

@mohammeds1992 mohammeds1992 merged commit bb487a6 into alpha Sep 29, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants