Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SDK-1420 Stream and UserProfile Fix #1419

Merged
merged 4 commits into from
Nov 7, 2024
Merged

Conversation

mishramonalisha76
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

github-actions bot commented Nov 6, 2024

In the first file (packages/uiweb/src/lib/components/chat/UserProfile/UserProfile.tsx):

  1. There is a typo in line 113 where Conatiner should be corrected to Container.
  2. There is a missing closing parenthesis ) in line 147 after the loading property of the customStyle object.
  3. The comment block related to the updateUserProfile function starting in line 61 is not properly closed.
  4. In the useEffect, the condition for onUserProfileUpdateModalOpen in line 59 should be checked for showUpdateUserProfileModal being true before invoking the function.
  5. The DropDownBar and DropDownItem components used in lines 158 and 165 are not defined within this file. Make sure these components are imported or defined.
  6. The closing tag for the UserProfile component is missing.

In the second file (packages/uiweb/src/lib/dataProviders/ChatDataProvider.tsx):

  1. There are several conditions missing closing braces } in the attachListenersAndConnect function starting in line 132. Each if block should be properly closed.
  2. There is a missing closing parenthesis ) in line 178 after setIsPushChatStreamConnected(true).
  3. There are multiple areas where comments are missing proper closure with closing */ sequence.
  4. In line 196, there is a missing closing parenthesis ) after the console.log statement inside the conditional block.
  5. The function initStream has an incomplete logic flow, and it's missing proper closing braces and conditions closures throughout the function.

All looks good.

Copy link

github-actions bot commented Nov 6, 2024

In the package.json file:

  1. The "peerDependencies" section is missing its closing curly brace }.
  2. The "devDependencies" section is missing its closing curly brace }.

In the UserProfile.tsx file:

  1. There is a typo in the opening <Conatiner tag. It should be <Container.
  2. The closing </DropDownBar> tag is missing its closing curly brace }.
  3. The setUserProfile function is being called with fetchChatProfile({ user }), which should be fetchChatProfile(user).
  4. The loading prop in the ProfileContainer component is missing a closing curly brace } after false.

In the ChatDataProvider.tsx file:

  1. The initStream function is missing its closing curly brace } after the attachListenersAndConnect function.
  2. There are missing closing curly braces } in various parts of the code, such as after setChatRejectStream(message);, setParticipantRemoveStream(message);, setParticipantLeaveStream(message);, setParticipantJoinStream(message);, and setGroupCreateStream(chatops);.
  3. The comments inside the attachListenersAndConnect function are not enclosed properly with console.debug statements.
  4. There is a commented-out code block starting with "// setTimeout(async () => {" and missing its closing curly brace }.

Please make the necessary corrections, and after that, write 'All looks good.'

@rohitmalhotra1420 rohitmalhotra1420 merged commit 573a858 into alpha Nov 7, 2024
1 check passed
@rohitmalhotra1420 rohitmalhotra1420 linked an issue Nov 7, 2024 that may be closed by this pull request
@rohitmalhotra1420 rohitmalhotra1420 changed the title Stream and UserProfile Fix SDK-1420 Stream and UserProfile Fix Nov 7, 2024
rohitmalhotra1420 added a commit that referenced this pull request Nov 7, 2024
* fixed chat responsiveness

* fixed preview link alignment to right

* added relative imports for better management

* Search issue (#1270)

* fix: fixed lint issues

* fix: added test for chat preview search list

* fix: fixed review comment

* Update ChatPreviewSearchList.tsx

* fix: fixed support chat init issue (#1292)

* fix: fixed support chat init issue

* fix: fixed lint errors

* fix(chatviewlist): increase hidden/encrypted chat blur

fix #1307

* Added Reaction support,  (#1303)

* Fixed responsiveness in mobile for UIWeb:Chat

* fixes text alignment on frames preview link to come on right

* scroll bar fixes

* fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group

* removed unnecessary console.debug

* removed unnecessary console.debug

* Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble

* Resolved comments

* fix: add selected option

* fix: add return fn

* fix: add comment to fn

* fix: add push bot address

* fix: export const

* fix: reset chat_id

* fix: remove console

* fix: update dark mode theme

* fix: code review comments

* fix: add null check

* fix: update conditions

* fix: pending wallet address copy issue fixed

When copying pending wallet address in the group info, only half of the wallet address was getting
copied

#1297

* fix: update chatprevie badge conditions

* fix: tooltip was not properly aligned

Tooltip was not properly aigned in the group Info in UIWeb

#1299

* fix: scrollbar in member list in group info was not visible

Fixed the scrollbar issue in the member list in group info in uiweb

#1298

* Space - id integration (#1322)

* feat: integrating spaceid in uiweb

* fix: fixed project id setting error

* fix: removed unnecessary code

* fix: added space id

* Update AddWallets.tsx

* fix: made some optimisations

* fix: fixed lint issues

---------

Co-authored-by: KlausMikhaelson <[email protected]>

* fix: fixed the blurr issue in chat on join and accept group (#1305)

* fix: fixed lint issue

* fixed build error for incorrect naming

* fixes ui representation for domain resolution (#1336)

* Main Release 1.3.7 (#1334)

* fixed chat responsiveness

* fixed preview link alignment to right

* added relative imports for better management

* Search issue (#1270)

* fix: fixed lint issues

* fix: added test for chat preview search list

* fix: fixed review comment

* Update ChatPreviewSearchList.tsx

* fix: fixed support chat init issue (#1292)

* fix: fixed support chat init issue

* fix: fixed lint errors

* fix(chatviewlist): increase hidden/encrypted chat blur

fix #1307

* Added Reaction support,  (#1303)

* Fixed responsiveness in mobile for UIWeb:Chat

* fixes text alignment on frames preview link to come on right

* scroll bar fixes

* fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group

* removed unnecessary console.debug

* removed unnecessary console.debug

* Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble

* Resolved comments

* fix: add selected option

* fix: add return fn

* fix: add comment to fn

* fix: add push bot address

* fix: export const

* fix: reset chat_id

* fix: remove console

* fix: update dark mode theme

* fix: code review comments

* fix: add null check

* fix: update conditions

* fix: update chatprevie badge conditions

* Space - id integration (#1322)

* feat: integrating spaceid in uiweb

* fix: fixed project id setting error

* fix: removed unnecessary code

* fix: added space id

* Update AddWallets.tsx

* fix: made some optimisations

* fix: fixed lint issues

---------

Co-authored-by: KlausMikhaelson <[email protected]>

* fix: fixed the blurr issue in chat on join and accept group (#1305)

* fix: fixed lint issue

---------

Co-authored-by: harshrajat <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Mohammed S <[email protected]>
Co-authored-by: corlard3y <[email protected]>
Co-authored-by: KlausMikhaelson <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* Main Release 1.3.7 - Build error fixed (#1335)

* fix: fixed the ui representation of the domain name

* fix: fixed the domain representation in chatProfile

* fix: added utility func to fetch display name

* fix: added new function to check includes

---------

Co-authored-by: Rohit Malhotra <[email protected]>
Co-authored-by: harshrajat <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: Mohammed S <[email protected]>
Co-authored-by: corlard3y <[email protected]>
Co-authored-by: KlausMikhaelson <[email protected]>

* fix: updated guild validation url (#1363)

* fix: updated guild validation url

* Update tokenGatedGroup.ts

* fix: fixed group creation (#1365)

* fix: fixed group creation

* fix: fixed the example file

* fix: fixed build

* fix: reverted restapi change

* fix: fix lint issues

* fix: made Group Chat Modal More Persistent (#1339)

* fix: made Group Chat Modal More Persistent

Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also,
added a boolean prop to make it go away when the clickaway is triggered

#1338

* fix: prop issue fixed for UpdateUserProfileModal file as well

* fix: added closeModalOnClickAway to ChatView and UserProfile component

* fix: changed the name of the Modal ClickAway in Group Info and User Profile

* fix: changed the name of modal clickaway prop for user profile and chat profile

* fix: fixed font sizes and dark theme (#1376)

* fix: fixed font sizes and dark theme

* fix: fixed line height

* Add erc1155 to token gating group conditions (#1382)

* feat: add erc1155 to token gating group conditions

* fix: add tokenId to fetchContractInfo function

* lock file updated

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390)

* fix: added common resolveweb3 for domain name

* fix: fixed review comments

* Notification Ui change (#1396)

* feat: new notification ui

* fix: fixed review comments

* lock file changed

* fix: fixed color and cta hover

* fix: fixed the review comments

* fix: fixed link icon

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Push Chat Reply Feature (#1399)

* Functioning reply in ChatPreviewList, ChatList and Input

* Reply cancel and replying to in UIWeb:MessageInput

* Reply Feature with styles

* fix: modified some parts in helper func

* fix: added the replied to text and also fixed the emoji picker position

added the replied to text in the chat bubble and fixed the emoji picker position also fixed the
breaking of the chat due to the messagetype issue

* fix: fixed the UI for the reply feature

changed the replying to to reply and also fixed the image positioning

* fix: fixed the issues

moved the funcs to helpers and also removed the commented code

* fix: fixed image in notification

* fix: added the commented code that was removed

---------

Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* uiweb lock file updated

* Add support for new chains in the chat criteria modal (#1404)

* fix: add cyber, linea and base

* fix: update cyber

* fix: fixed the theme for chat reply feature

fixed the UI of the chat reply

* Added new infura key (#1408)

* fix: fixed infura key

* fix: fixed build issue

* fix: changed infura key

* fix: fixed review comments

* fix: fixed review comment

* lock files  fixed

* fix: fixed the twitter preview Size issue

* fix: modified the address for the reply preview

* Release 1.7.0 (#1411) (#1413)

* fix: fixed font sizes and dark theme (#1376)

* fix: fixed font sizes and dark theme

* fix: fixed line height

* Add erc1155 to token gating group conditions (#1382)

* feat: add erc1155 to token gating group conditions

* fix: add tokenId to fetchContractInfo function

* lock file updated

---------



* Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390)

* fix: added common resolveweb3 for domain name

* fix: fixed review comments

* Notification Ui change (#1396)

* feat: new notification ui

* fix: fixed review comments

* lock file changed

* fix: fixed color and cta hover

* fix: fixed the review comments

* fix: fixed link icon

---------



* Push Chat Reply Feature (#1399)

* Functioning reply in ChatPreviewList, ChatList and Input

* Reply cancel and replying to in UIWeb:MessageInput

* Reply Feature with styles

* fix: modified some parts in helper func

* fix: added the replied to text and also fixed the emoji picker position

added the replied to text in the chat bubble and fixed the emoji picker position also fixed the
breaking of the chat due to the messagetype issue

* fix: fixed the UI for the reply feature

changed the replying to to reply and also fixed the image positioning

* fix: fixed the issues

moved the funcs to helpers and also removed the commented code

* fix: fixed image in notification

* fix: added the commented code that was removed

---------




* uiweb lock file updated

* Add support for new chains in the chat criteria modal (#1404)

* fix: add cyber, linea and base

* fix: update cyber

* Added new infura key (#1408)

* fix: fixed infura key

* fix: fixed build issue

* fix: changed infura key

* fix: fixed review comments

* fix: fixed review comment

* lock files  fixed

---------

Co-authored-by: Rohit Malhotra <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Kolade <[email protected]>

* Revert "Release 1.7.0 (#1411) (#1413)" (#1414)

This reverts commit f96f451.

* Stream fixes (#1417)

* Release 1.7.0 (#1411)

* fix: fixed font sizes and dark theme (#1376)

* fix: fixed font sizes and dark theme

* fix: fixed line height

* Add erc1155 to token gating group conditions (#1382)

* feat: add erc1155 to token gating group conditions

* fix: add tokenId to fetchContractInfo function

* lock file updated

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390)

* fix: added common resolveweb3 for domain name

* fix: fixed review comments

* Notification Ui change (#1396)

* feat: new notification ui

* fix: fixed review comments

* lock file changed

* fix: fixed color and cta hover

* fix: fixed the review comments

* fix: fixed link icon

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Push Chat Reply Feature (#1399)

* Functioning reply in ChatPreviewList, ChatList and Input

* Reply cancel and replying to in UIWeb:MessageInput

* Reply Feature with styles

* fix: modified some parts in helper func

* fix: added the replied to text and also fixed the emoji picker position

added the replied to text in the chat bubble and fixed the emoji picker position also fixed the
breaking of the chat due to the messagetype issue

* fix: fixed the UI for the reply feature

changed the replying to to reply and also fixed the image positioning

* fix: fixed the issues

moved the funcs to helpers and also removed the commented code

* fix: fixed image in notification

* fix: added the commented code that was removed

---------

Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* uiweb lock file updated

* Add support for new chains in the chat criteria modal (#1404)

* fix: add cyber, linea and base

* fix: update cyber

* Added new infura key (#1408)

* fix: fixed infura key

* fix: fixed build issue

* fix: changed infura key

* fix: fixed review comments

* fix: fixed review comment

* lock files  fixed

---------

Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Kolade <[email protected]>

* Release 1.7.1 (#1412)

* fix: fixed font sizes and dark theme (#1376)

* fix: fixed font sizes and dark theme

* fix: fixed line height

* Add erc1155 to token gating group conditions (#1382)

* feat: add erc1155 to token gating group conditions

* fix: add tokenId to fetchContractInfo function

* lock file updated

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390)

* fix: added common resolveweb3 for domain name

* fix: fixed review comments

* Notification Ui change (#1396)

* feat: new notification ui

* fix: fixed review comments

* lock file changed

* fix: fixed color and cta hover

* fix: fixed the review comments

* fix: fixed link icon

---------

Co-authored-by: rohitmalhotra1420 <[email protected]>

* Push Chat Reply Feature (#1399)

* Functioning reply in ChatPreviewList, ChatList and Input

* Reply cancel and replying to in UIWeb:MessageInput

* Reply Feature with styles

* fix: modified some parts in helper func

* fix: added the replied to text and also fixed the emoji picker position

added the replied to text in the chat bubble and fixed the emoji picker position also fixed the
breaking of the chat due to the messagetype issue

* fix: fixed the UI for the reply feature

changed the replying to to reply and also fixed the image positioning

* fix: fixed the issues

moved the funcs to helpers and also removed the commented code

* fix: fixed image in notification

* fix: added the commented code that was removed

---------

Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>

* uiweb lock file updated

* Add support for new chains in the chat criteria modal (#1404)

* fix: add cyber, linea and base

* fix: update cyber

* fix: fixed the theme for chat reply feature

fixed the UI of the chat reply

* Added new infura key (#1408)

* fix: fixed infura key

* fix: fixed build issue

* fix: changed infura key

* fix: fixed review comments

* fix: fixed review comment

* lock files  fixed

* fix: fixed the twitter preview Size issue

* fix: modified the address for the reply preview

* Release 1.7.0 (#1411) (#1413)

* fix: fixed font sizes and dark theme (#1376)

* fix: fixed font sizes and dark theme

* fix: fixed line height

* Add erc1155 to token gating group conditions (#1382)

* feat: add erc1155 to token gating group conditions

* fix: add tokenId to fetchContractInfo function

* lock file updated

---------



* Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390)

* fix: added common resolveweb3 for domain name

* fix: fixed review comments

* Notification Ui change (#1396)

* feat: new notification ui

* fix: fixed review comments

* lock file changed

* fix: fixed color and cta hover

* fix: fixed the review comments

* fix: fixed link icon

---------



* Push Chat Reply Feature (#1399)

* Functioning reply in ChatPreviewList, ChatList and Input

* Reply cancel and replying to in UIWeb:MessageInput

* Reply Feature with styles

* fix: modified some parts in helper func

* fix: added the replied to text and also fixed the emoji picker position

added the replied to text in the chat bubble and fixed the emoji picker position also fixed the
breaking of the chat due to the messagetype issue

* fix: fixed the UI for the reply feature

changed the replying to to reply and also fixed the image positioning

* fix: fixed the issues

moved the funcs to helpers and also removed the commented code

* fix: fixed image in notification

* fix: added the commented code that was removed

---------




* uiweb lock file updated

* Add support for new chains in the chat criteria modal (#1404)

* fix: add cyber, linea and base

* fix: update cyber

* Added new infura key (#1408)

* fix: fixed infura key

* fix: fixed build issue

* fix: changed infura key

* fix: fixed review comments

* fix: fixed review comment

* lock files  fixed

---------

Co-authored-by: Rohit Malhotra <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Kolade <[email protected]>

* Revert "Release 1.7.0 (#1411) (#1413)" (#1414)

This reverts commit f96f451.

---------

Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: rohitmalhotra1420 <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Kolade <[email protected]>
Co-authored-by: Abhishek <[email protected]>

* fix: stream handling multiplier listeners

* fix: build issue

* fix: added logs

* fix: added type

* fix: stream fix

* fix: logs removal

* Update package.json

* Update UserProfile.tsx

* Update ChatDataProvider.tsx

* Update ChatDataProvider.tsx

* fix: fix log

---------

Co-authored-by: Rohit Malhotra <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Kolade <[email protected]>
Co-authored-by: Abhishek <[email protected]>

* Stream and UserProfile Fix (#1419)

* fix: fixed stream issue

* fix: added new restapi version

---------

Co-authored-by: harshrajat <[email protected]>
Co-authored-by: Harsh | Push <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Mohammed S <[email protected]>
Co-authored-by: corlard3y <[email protected]>
Co-authored-by: abhishek-01k <[email protected]>
Co-authored-by: KlausMikhaelson <[email protected]>
Co-authored-by: Monalisha Mishra <[email protected]>
Co-authored-by: Abhishek <[email protected]>
Co-authored-by: aman035 <[email protected]>
Co-authored-by: Kalash Shah <[email protected]>
Co-authored-by: Mohammed S <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix the chat stream issue on sdk
2 participants