Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: fix tc running #1379

Merged
merged 1 commit into from
Jul 18, 2024
Merged

chore: fix tc running #1379

merged 1 commit into from
Jul 18, 2024

Conversation

Aman035
Copy link
Member

@Aman035 Aman035 commented Jul 18, 2024

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Copy link

  • There is a typo in the code: .Throw should be changed to .throw in all expect statements.
  • In the test case With signer and provider :: should add tags, the timeout syntax is incorrect. It should be this.timeout(10000) at the beginning of the test function.
  • In the test cases related to adding, updating, and removing tags, the implementation of expect assertions should be reviewed for correctness as per the logic of the code.
  • It seems the commented out code related to checking the existence of the .env file and verifying the environment setup should be reviewed and potentially cleaned up as it is unnecessary for the current implementation.
All looks good.

@Aman035 Aman035 merged commit 0bf1b9b into main Jul 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants