Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support chatId for one to one in send message #1350

Merged

Conversation

mohammeds1992
Copy link
Collaborator

Fixes Issue

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Note to reviewers

Sorry, something went wrong.

@mohammeds1992 mohammeds1992 requested a review from Aman035 June 12, 2024 15:04
@mohammeds1992 mohammeds1992 linked an issue Jun 12, 2024 that may be closed by this pull request
Copy link

In packages/restapi/src/lib/chat/helpers/payloadHelper.ts:

  1. In the sendMessagePayloadCore function, there is a missing comma after the pgpHelper: IPGPHelper parameter declaration.
  2. In the sendMessagePayloadCore function, there is a missing closing parenthesis after the pgpHelper: IPGPHelper parameter declaration.
  3. In the sendMessagePayloadCore function, there is a missing closing parenthesis after the first call to getEncryptedRequestCore.
  4. In the sendMessagePayloadCore function, there is a missing closing parenthesis after the second call to getEncryptedRequestCore.

In packages/restapi/src/lib/chat/send.ts:

  1. In the sendCore function, there is a missing comma after the pgpHelper: IPGPHelper parameter declaration.

Please correct these issues.

All looks good.

@mohammeds1992 mohammeds1992 merged commit 4aa6e97 into main Jun 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cache to chat info API in send message flow
2 participants