-
Notifications
You must be signed in to change notification settings - Fork 53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: made Group Chat Modal More Persistent #1339
fix: made Group Chat Modal More Persistent #1339
Conversation
Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also, added a boolean prop to make it go away when the clickaway is triggered #1338
In the file
In the file
In the file
Please make the necessary corrections to resolve these issues. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Let's do a exp release for this change and test it out on DApp.
File: packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfileInfoModal.tsx
File: packages/uiweb/src/lib/components/chat/CreateGroup/CreateGroupModal.tsx
File: packages/uiweb/src/lib/components/chat/UserProfile/UpdateUserProfileModal.tsx
Overall the code seems to be structured properly with minor issues mentioned above. Please address those and run a thorough check before finalizing the changes. All looks good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR looks good. Just wanted to know what's the reason for updated yarn.lock files?
Created an exp release for this version -> 1.0.0-exp.13 |
packages/uiweb/src/lib/components/chat/UserProfile/UserProfile.tsx
Outdated
Show resolved
Hide resolved
packages/uiweb/src/lib/components/chat/UserProfile/UserProfile.tsx
Outdated
Show resolved
Hide resolved
packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx
Outdated
Show resolved
Hide resolved
In the file packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfile.tsx:
Apart from these issues, the code looks fine. In the file packages/uiweb/src/lib/components/chat/ChatProfile/ChatProfileInfoModal.tsx:
The rest of the content in the provided files seems to be fine. For specific errors not mentioned above or for any further assistance, please provide more context or details. |
In the code provided in the ChatProfile.tsx file, there are a few mistakes and issues that need to be addressed:
Please make sure to address these issues in the code before proceeding. |
* fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: pending wallet address copy issue fixed When copying pending wallet address in the group info, only half of the wallet address was getting copied #1297 * fix: update chatprevie badge conditions * fix: tooltip was not properly aligned Tooltip was not properly aigned in the group Info in UIWeb #1299 * fix: scrollbar in member list in group info was not visible Fixed the scrollbar issue in the member list in group info in uiweb #1298 * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue * fixed build error for incorrect naming * fixes ui representation for domain resolution (#1336) * Main Release 1.3.7 (#1334) * fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: update chatprevie badge conditions * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * Main Release 1.3.7 - Build error fixed (#1335) * fix: fixed the ui representation of the domain name * fix: fixed the domain representation in chatProfile * fix: added utility func to fetch display name * fix: added new function to check includes --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> * fix: updated guild validation url (#1363) * fix: updated guild validation url * Update tokenGatedGroup.ts * fix: fixed group creation (#1365) * fix: fixed group creation * fix: fixed the example file * fix: fixed build * fix: reverted restapi change * fix: fix lint issues * fix: made Group Chat Modal More Persistent (#1339) * fix: made Group Chat Modal More Persistent Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also, added a boolean prop to make it go away when the clickaway is triggered #1338 * fix: prop issue fixed for UpdateUserProfileModal file as well * fix: added closeModalOnClickAway to ChatView and UserProfile component * fix: changed the name of the Modal ClickAway in Group Info and User Profile * fix: changed the name of modal clickaway prop for user profile and chat profile --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: rohitmalhotra1420 <[email protected]> Co-authored-by: Abhishek <[email protected]> Co-authored-by: aman035 <[email protected]>
* fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: pending wallet address copy issue fixed When copying pending wallet address in the group info, only half of the wallet address was getting copied #1297 * fix: update chatprevie badge conditions * fix: tooltip was not properly aligned Tooltip was not properly aigned in the group Info in UIWeb #1299 * fix: scrollbar in member list in group info was not visible Fixed the scrollbar issue in the member list in group info in uiweb #1298 * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue * fixed build error for incorrect naming * fixes ui representation for domain resolution (#1336) * Main Release 1.3.7 (#1334) * fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: update chatprevie badge conditions * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * Main Release 1.3.7 - Build error fixed (#1335) * fix: fixed the ui representation of the domain name * fix: fixed the domain representation in chatProfile * fix: added utility func to fetch display name * fix: added new function to check includes --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> * fix: updated guild validation url (#1363) * fix: updated guild validation url * Update tokenGatedGroup.ts * fix: fixed group creation (#1365) * fix: fixed group creation * fix: fixed the example file * fix: fixed build * fix: reverted restapi change * fix: fix lint issues * fix: made Group Chat Modal More Persistent (#1339) * fix: made Group Chat Modal More Persistent Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also, added a boolean prop to make it go away when the clickaway is triggered #1338 * fix: prop issue fixed for UpdateUserProfileModal file as well * fix: added closeModalOnClickAway to ChatView and UserProfile component * fix: changed the name of the Modal ClickAway in Group Info and User Profile * fix: changed the name of modal clickaway prop for user profile and chat profile * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * fix: fixed the theme for chat reply feature fixed the UI of the chat reply * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed * fix: fixed the twitter preview Size issue * fix: modified the address for the reply preview * Release 1.7.0 (#1411) (#1413) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> * Revert "Release 1.7.0 (#1411) (#1413)" (#1414) This reverts commit f96f451. * Stream fixes (#1417) * Release 1.7.0 (#1411) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kolade <[email protected]> * Release 1.7.1 (#1412) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * fix: fixed the theme for chat reply feature fixed the UI of the chat reply * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed * fix: fixed the twitter preview Size issue * fix: modified the address for the reply preview * Release 1.7.0 (#1411) (#1413) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> * Revert "Release 1.7.0 (#1411) (#1413)" (#1414) This reverts commit f96f451. --------- Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: rohitmalhotra1420 <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> Co-authored-by: Abhishek <[email protected]> * fix: stream handling multiplier listeners * fix: build issue * fix: added logs * fix: added type * fix: stream fix * fix: logs removal * Update package.json * Update UserProfile.tsx * Update ChatDataProvider.tsx * Update ChatDataProvider.tsx * fix: fix log --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kolade <[email protected]> Co-authored-by: Abhishek <[email protected]> --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: rohitmalhotra1420 <[email protected]> Co-authored-by: Abhishek <[email protected]> Co-authored-by: aman035 <[email protected]> Co-authored-by: Kalash Shah <[email protected]>
* fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: pending wallet address copy issue fixed When copying pending wallet address in the group info, only half of the wallet address was getting copied #1297 * fix: update chatprevie badge conditions * fix: tooltip was not properly aligned Tooltip was not properly aigned in the group Info in UIWeb #1299 * fix: scrollbar in member list in group info was not visible Fixed the scrollbar issue in the member list in group info in uiweb #1298 * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue * fixed build error for incorrect naming * fixes ui representation for domain resolution (#1336) * Main Release 1.3.7 (#1334) * fixed chat responsiveness * fixed preview link alignment to right * added relative imports for better management * Search issue (#1270) * fix: fixed lint issues * fix: added test for chat preview search list * fix: fixed review comment * Update ChatPreviewSearchList.tsx * fix: fixed support chat init issue (#1292) * fix: fixed support chat init issue * fix: fixed lint errors * fix(chatviewlist): increase hidden/encrypted chat blur fix #1307 * Added Reaction support, (#1303) * Fixed responsiveness in mobile for UIWeb:Chat * fixes text alignment on frames preview link to come on right * scroll bar fixes * fixed reaction picker position, tweaked group type text, removed add button from define conditions in gated group * removed unnecessary console.debug * removed unnecessary console.debug * Resolved comments, fixed curved edges go away, fixed correct time placement in ChatBubble * Resolved comments * fix: add selected option * fix: add return fn * fix: add comment to fn * fix: add push bot address * fix: export const * fix: reset chat_id * fix: remove console * fix: update dark mode theme * fix: code review comments * fix: add null check * fix: update conditions * fix: update chatprevie badge conditions * Space - id integration (#1322) * feat: integrating spaceid in uiweb * fix: fixed project id setting error * fix: removed unnecessary code * fix: added space id * Update AddWallets.tsx * fix: made some optimisations * fix: fixed lint issues --------- Co-authored-by: KlausMikhaelson <[email protected]> * fix: fixed the blurr issue in chat on join and accept group (#1305) * fix: fixed lint issue --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * Main Release 1.3.7 - Build error fixed (#1335) * fix: fixed the ui representation of the domain name * fix: fixed the domain representation in chatProfile * fix: added utility func to fetch display name * fix: added new function to check includes --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> * fix: updated guild validation url (#1363) * fix: updated guild validation url * Update tokenGatedGroup.ts * fix: fixed group creation (#1365) * fix: fixed group creation * fix: fixed the example file * fix: fixed build * fix: reverted restapi change * fix: fix lint issues * fix: made Group Chat Modal More Persistent (#1339) * fix: made Group Chat Modal More Persistent Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also, added a boolean prop to make it go away when the clickaway is triggered #1338 * fix: prop issue fixed for UpdateUserProfileModal file as well * fix: added closeModalOnClickAway to ChatView and UserProfile component * fix: changed the name of the Modal ClickAway in Group Info and User Profile * fix: changed the name of modal clickaway prop for user profile and chat profile * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * fix: fixed the theme for chat reply feature fixed the UI of the chat reply * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed * fix: fixed the twitter preview Size issue * fix: modified the address for the reply preview * Release 1.7.0 (#1411) (#1413) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> * Revert "Release 1.7.0 (#1411) (#1413)" (#1414) This reverts commit f96f451. * Stream fixes (#1417) * Release 1.7.0 (#1411) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kolade <[email protected]> * Release 1.7.1 (#1412) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- Co-authored-by: rohitmalhotra1420 <[email protected]> * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * fix: fixed the theme for chat reply feature fixed the UI of the chat reply * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed * fix: fixed the twitter preview Size issue * fix: modified the address for the reply preview * Release 1.7.0 (#1411) (#1413) * fix: fixed font sizes and dark theme (#1376) * fix: fixed font sizes and dark theme * fix: fixed line height * Add erc1155 to token gating group conditions (#1382) * feat: add erc1155 to token gating group conditions * fix: add tokenId to fetchContractInfo function * lock file updated --------- * Replaced useResolveWeb3Name hook with resolveWeb3Name helper function (#1390) * fix: added common resolveweb3 for domain name * fix: fixed review comments * Notification Ui change (#1396) * feat: new notification ui * fix: fixed review comments * lock file changed * fix: fixed color and cta hover * fix: fixed the review comments * fix: fixed link icon --------- * Push Chat Reply Feature (#1399) * Functioning reply in ChatPreviewList, ChatList and Input * Reply cancel and replying to in UIWeb:MessageInput * Reply Feature with styles * fix: modified some parts in helper func * fix: added the replied to text and also fixed the emoji picker position added the replied to text in the chat bubble and fixed the emoji picker position also fixed the breaking of the chat due to the messagetype issue * fix: fixed the UI for the reply feature changed the replying to to reply and also fixed the image positioning * fix: fixed the issues moved the funcs to helpers and also removed the commented code * fix: fixed image in notification * fix: added the commented code that was removed --------- * uiweb lock file updated * Add support for new chains in the chat criteria modal (#1404) * fix: add cyber, linea and base * fix: update cyber * Added new infura key (#1408) * fix: fixed infura key * fix: fixed build issue * fix: changed infura key * fix: fixed review comments * fix: fixed review comment * lock files fixed --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> * Revert "Release 1.7.0 (#1411) (#1413)" (#1414) This reverts commit f96f451. --------- Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: rohitmalhotra1420 <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Kolade <[email protected]> Co-authored-by: Abhishek <[email protected]> * fix: stream handling multiplier listeners * fix: build issue * fix: added logs * fix: added type * fix: stream fix * fix: logs removal * Update package.json * Update UserProfile.tsx * Update ChatDataProvider.tsx * Update ChatDataProvider.tsx * fix: fix log --------- Co-authored-by: Rohit Malhotra <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Kolade <[email protected]> Co-authored-by: Abhishek <[email protected]> * Stream and UserProfile Fix (#1419) * fix: fixed stream issue * fix: added new restapi version --------- Co-authored-by: harshrajat <[email protected]> Co-authored-by: Harsh | Push <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Mohammed S <[email protected]> Co-authored-by: corlard3y <[email protected]> Co-authored-by: abhishek-01k <[email protected]> Co-authored-by: KlausMikhaelson <[email protected]> Co-authored-by: Monalisha Mishra <[email protected]> Co-authored-by: Abhishek <[email protected]> Co-authored-by: aman035 <[email protected]> Co-authored-by: Kalash Shah <[email protected]> Co-authored-by: Mohammed S <[email protected]>
Modal in the group chat has been modified and now it doesn't close on the clickaway triggered. Also, added a boolean prop to make it go away when the clickaway is triggered
#1338
Fixes Issue
Closes: #1388
Changes proposed
Check List (Check all the applicable boxes)
Note to reviewers
To check the functionality follow these methods:
On dapp side, where we are importing CreateGroupModal
If you pass closeonClickAway = true along with onClose function from the dapp side, the modal will be non persistent i.e, it will close when their is a clickaway
<CreateGroupModal onClose={() => handleClose()} closeonClickAway/>
if you pass only onClose function on the dapp, the modal will be persistent and it will not close if you click outside the modal.
<CreateGroupModal onClose={() => handleClose()}/>