Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: scrollbar in member list in group info was not visible #1329

Merged
merged 2 commits into from
May 31, 2024

Conversation

abhishek-01k
Copy link
Collaborator

Fixes Issue

Closes: #1298

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2024-05-29 at 4 17 00 PM

Fixed the scrollbar issue in the member list in group info in uiweb

#1298
Copy link

In the file PendingMembers.tsx:

  1. There seems to be a missing closing parenthesis } after the else block.
  2. There are missing closing parentheses } for the const removeAdminDropdown, const addAdminDropdown, and const removeMemberDropdown.
  3. There is a missing semicolon ; at the end of the line where the useClickAway function is called.
  4. There is missing const before the useClickAway function call.
  5. In the GroupPendingMembers styled component, the closing backtick for the template string is missing.
  6. In the PendingRequestWrapper styled component, the closing backtick for the template string is missing.
  7. In the ArrowImage styled component, there is an issue with the transform property where rotate(180deg) does not have a closing parenthesis.
  8. In the ProfileSection styled component, several closing curly braces are missing for pseudo-elements (::-webkit-scrollbar-thumb, ::-webkit-scrollbar-button, ::-webkit-scrollbar).

In the file ChatViewList.tsx:

  1. There is a missing closing curly brace } for the first useEffect.
  2. The closing curly braces for the useEffect hooks seem to be misplaced.
  3. In the transformSteamMessage function, there is a missing closing curly brace } after the if (!user) { block.

Once the above issues are corrected, please ensure that the entire code logic is still intact and no functional errors are introduced.

If everything is correct after the corrections, you can write 'All looks good.'

Copy link

In the PendingMembers.tsx file:

  1. Missing closing curly brace } for the removeAdminDropdown and addAdminDropdown objects.
  2. Missing closing curly brace } for the removeMemberDropdown object.
  3. useClickAway hook should be inside the functional component or inside an useEffect hook.
  4. The DropdownValueType objects are missing a closing curly brace } after the function property.
  5. The GroupPendingMembers styled component is missing a closing backtick }.
  6. The PendingRequestWrapper and PendingSection styled components are missing closing backticks }.
  7. The arrow function in ArrowImage styled component has incorrect syntax within the transform property.
  8. Missing closing backticks } for the Badge styled component.
  9. The ProfileSection styled component is missing closing curly braces } for the &::-webkit-scrollbar-thumb, &::-webkit-scrollbar-button, and &::-webkit-scrollbar.

In the ChatViewList.tsx file:

  1. Object.keys(participantRemoveStream || {}).length > 0 && participantRemoveStream.constructor === Object) is missing a conditional statement.
  2. The updatedChatInfo object properties are not correctly enclosed within the if statement block.
  3. The closing curly brace } for the useEffect hook with chatAcceptStream and participantJoinStream dependencies should be before the block that returns the cleanup function.
  4. if (!user) { return; missing closing curly brace }.
  5. Missing closing parenthesis } for the transformSteamMessage function.
  6. if (messages && messages.length) { missing closing curly brace }.
  7. In the HTML output section, missing closing parenthesis ) for the function call renderDate.
  8. The last closing backtick } for the ChatViewListCardInner styled component is missing.

Please correct these issues and rerun the code review.

@abhishek-01k abhishek-01k merged commit 7877b61 into alpha May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - <in uiweb/chat> Members list does not display scrollbar
2 participants