Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: tooltip was not properly aligned #1328

Merged
merged 1 commit into from
May 31, 2024

Conversation

abhishek-01k
Copy link
Collaborator

Tooltip was not properly aigned in the group Info in UIWeb

#1299

Fixes Issue

Closes: #1299

Changes proposed

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • This PR does not contain plagiarized content.
  • The title of my pull request is a short description of the requested changes.

Screenshots

Screenshot 2024-05-29 at 2 37 59 PM

Tooltip was not properly aigned in the group Info in UIWeb

#1299
@abhishek-01k abhishek-01k linked an issue May 29, 2024 that may be closed by this pull request
Copy link

In ChatProfileInfoModal.tsx:

  1. In the GroupDescription styled component, the closing backtick for the styled component is missing, it should be:
const GroupDescription = styled.div`
  flex-direction: column;
  align-items: flex-start;
  gap: 5px;
`;
  1. In the PublicEncrypted styled component, the closing backtick is missing, and the last bracket should be } instead of {:
const PublicEncrypted = styled(Section) <{ alert?: boolean }>`
  gap: 12px;
  align-items: center;
  border: ${(props) => (props?.alert ? '1px solid #E93636' : props.theme.border.modalInnerComponents)};
  border-radius: ${(props) => props.theme.borderRadius.modalInnerComponents};
  padding: 12px 16px;
  box-sizing: border-box;
  background: ${(props) => props.theme.backgroundColor.modalHoverBackground};
`;
  1. In the AddWalletContainer styled component, the closing backtick is missing, and it should end with a } instead of {:
const AddWalletContainer = styled.div`
  border: ${(props) => props.theme.border.modalInnerComponents};
  padding: 20px 16px;
  justify-content: center;
  cursor: pointer;
`;
  1. In the ConditionSection styled component, there are missing closing brackets } for some pseudo-selectors, it should be:
const ConditionSection = styled(Section) <{ theme: IChatTheme }>`
  &::-webkit-scrollbar-thumb {
    background: ${(props) => props.theme.scrollbarColor};
    border-radius: 10px;
  }
  &::-webkit-scrollbar-button {
    height: 20px;
  }
  &::-webkit-scrollbar {
    width: 4px;
`;

In PendingMembers.tsx:

  1. In the useClickAway line, the closing parenthesis is missing:
useClickAway(dropdownRef, () => setSelectedMemberAddress(null));

Please correct these issues. After correction, the code looks good.

Copy link
Collaborator

@mishramonalisha76 mishramonalisha76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@abhishek-01k abhishek-01k merged commit cc8dc28 into alpha May 31, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

🐛 [BUG] - <in uiweb> Tooltip not properly aligned
2 participants